From: timur@tabi•org (Timur Tabi)
To: linux-arm-kernel@lists•infradead.org
Subject: [alsa-devel] [PATCH] ASoC: fsl-ssi: fix SDMA starvation
Date: Wed, 13 Nov 2013 07:10:49 -0600 [thread overview]
Message-ID: <52837A59.5070508@tabi.org> (raw)
In-Reply-To: <20131113121630.GH30263@pengutronix.de>
Markus Pargmann wrote:
>> >Can you change the code so that the interrupts are enabled only on
>> >i.MX? On PowerPC, the interrupts are used only for debugging.
> Why is this necessary? The interrupts were enabled for all
> architectures before.
My concern is with these lines:
write_ssi_mask(&ssi->sier, 0, CCSR_SSI_SIER_TDMAE);
...
write_ssi_mask(&ssi->sier, CCSR_SSI_SIER_TDMAE, 0);
This toggles the TDMAE interrupt on PowerPC, which I believe is VITAL to
making it work. The SSI and the DMA controller talk to each other
automatically, and if I'm reading the documentation correctly, that
communication depends on TDMAE and RDMAE.
next prev parent reply other threads:[~2013-11-13 13:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-12 11:17 [PATCH] ASoC: fsl-ssi: fix SDMA starvation Markus Pargmann
2013-11-12 12:55 ` Timur Tabi
2013-11-12 13:24 ` Markus Pargmann
2013-11-12 20:17 ` [alsa-devel] " Timur Tabi
2013-11-13 8:31 ` Jürgen Beisert
2013-11-13 13:11 ` Timur Tabi
2013-11-13 12:16 ` Markus Pargmann
2013-11-13 13:10 ` Timur Tabi [this message]
2013-11-13 13:38 ` Markus Pargmann
2013-11-13 14:15 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52837A59.5070508@tabi.org \
--to=timur@tabi$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox