From: javier.martinez@collabora•co.uk (Javier Martinez Canillas)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 11/11] OMAPDSS: DPI: use VPLL2 regulator if VDDS_DSI is not found
Date: Sat, 16 Nov 2013 18:28:00 +0100 [thread overview]
Message-ID: <5287AB20.9070407@collabora.co.uk> (raw)
In-Reply-To: <20131116160234.GB5104@earth.universe>
Hi Sebastian,
On 11/16/2013 05:02 PM, Sebastian Reichel wrote:
> On Sat, Nov 16, 2013 at 07:45:07AM -0800, Tony Lindgren wrote:
>> Well let's see what Tomi prefers.
>>
>> > > &vaux1 {
>> > > /* Needed for ads7846 */
>> > > regulator-name = "vcc";
>> > > };
>> > >
>> > > &vpll2 {
>> > > /* Needed for DSS */
>> > > regulator-name = "vdds_dsi";
>> > > };
>>
>> In the long we'll use regulator phandles anyways in the DSS related
>> nodes, so from that point of view fixing dpi.c makes sense.
>
> The hack, as being sent by Javier, will result in the wrong
> regulator being used on the Nokia N900, which is using vaux1.
> It must depend on the machine.
>
I see, so this hack is not generic enough to be usable for all OMAP3 boards so I
think is better to just add the hack on the DTS.
I was more found about adding a hack on dpi.c since the DTB is an stable ABI
while the dpi.c implementation is not. But I guess is not that bad to change the
DTS later once DSS DT bindings are added to mainline.
> At the same time the N900 device tree file uses V28 as
> regulator-name for vaux1 (which is the same one as legacy boot
> used). Nothing depends on this, but I don't think it's a
> good idea to use this property. Apparently it does not work
> if multiple drivers need the same regulator under different
> names.
>
> -- Sebastian
>
So, what do you think about the following patch instead?
>From 99f1c60f6db6cac07ea2c0398a9cbb3525dfdd72 Mon Sep 17 00:00:00 2001
From: Javier Martinez Canillas <javier.martinez@collabora•co.uk>
Date: Sat, 16 Nov 2013 17:59:08 +0100
Subject: [PATCH 1/1] ARM: dts: omap3-igep0020: name twl4030 VPLL2 regulator as
vdds_dsi
On Device Tree boot the VDDS_DSI regulator is not linked to
the DPI device so omapfb driver probing fails with:
[ 3.186035] OMAPFB: omapfb_probe
[ 3.190704] omapdss DPI error: can't get VDDS_DSI regulator
[ 3.196594] omapfb omapfb: failed to connect default display
[ 3.202667] omapfb omapfb: failed to init overlay connections
[ 3.208892] OMAPFB: free_resources
[ 3.212493] OMAPFB: free all fbmem
[ 3.216735] omapfb omapfb: failed to setup omapfb
As a workaround name the VPLL2 regulator from twl4030 as "vdds_dsi"
so getting the VDDS_DSI regulator will succeed on dpi_init_regulator().
Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora•co.uk>
---
arch/arm/boot/dts/omap3-igep0020.dts | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/omap3-igep0020.dts
b/arch/arm/boot/dts/omap3-igep0020.dts
index b9a9e17..1c7e74d 100644
--- a/arch/arm/boot/dts/omap3-igep0020.dts
+++ b/arch/arm/boot/dts/omap3-igep0020.dts
@@ -215,3 +215,8 @@
&usbhsehci {
phys = <&hsusb1_phy>;
};
+
+&vpll2 {
+ /* Needed for DSS */
+ regulator-name = "vdds_dsi";
+};
--
1.8.4.2
next prev parent reply other threads:[~2013-11-16 17:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-16 13:23 [PATCH 00/11]: add remaining support for IGEP boards Javier Martinez Canillas
2013-11-16 13:23 ` [PATCH 01/11] ARM: dts: omap3-igep: Fix bus-width for mmc1 Javier Martinez Canillas
2013-11-16 13:23 ` [PATCH 02/11] ARM: dts: omap3-igep: Add support for LBEE1USJYC WiFi connected to SDIO Javier Martinez Canillas
2013-11-16 13:23 ` [PATCH 03/11] ARM: dts: omap3-igep: Update to use the TI AM/DM37x processor Javier Martinez Canillas
2013-11-16 14:44 ` Tony Lindgren
2013-11-16 15:19 ` Javier Martinez Canillas
2013-11-16 15:22 ` Tony Lindgren
2013-11-16 13:23 ` [PATCH 04/11] ARM: dts: omap3-igep0020: Add pinmux setup for i2c devices Javier Martinez Canillas
2013-11-16 13:23 ` [PATCH 05/11] ARM: dts: omap3-igep0020: Add pinmuxing for DVI output Javier Martinez Canillas
2013-11-16 13:23 ` [PATCH 06/11] ARM: dts: AM33XX BASE0033: add pinmux and hdmi node to enable display Javier Martinez Canillas
2013-11-16 13:23 ` [PATCH 07/11] ARM: dts: AM33XX BASE0033: add pinmux and user led support Javier Martinez Canillas
2013-11-16 13:23 ` [PATCH 08/11] ARM: dts: AM33XX BASE0033: add 32KBit EEPROM support Javier Martinez Canillas
2013-11-16 13:23 ` [PATCH 09/11] ARM: dts: AM33XX IGEP0033: add USB support Javier Martinez Canillas
2013-11-16 13:23 ` [PATCH 10/11] ARM: OMAP: dss-common: change IGEP's DVI DDC i2c bus Javier Martinez Canillas
2013-11-16 13:23 ` [PATCH 11/11] OMAPDSS: DPI: use VPLL2 regulator if VDDS_DSI is not found Javier Martinez Canillas
2013-11-16 14:18 ` Tony Lindgren
2013-11-16 15:34 ` Javier Martinez Canillas
2013-11-16 15:45 ` Tony Lindgren
2013-11-16 16:02 ` Sebastian Reichel
2013-11-16 17:28 ` Javier Martinez Canillas [this message]
2013-11-17 0:26 ` Sebastian Reichel
2013-11-17 1:06 ` Javier Martinez Canillas
2013-11-16 14:16 ` [PATCH 00/11]: add remaining support for IGEP boards Tony Lindgren
2013-11-16 14:41 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5287AB20.9070407@collabora.co.uk \
--to=javier.martinez@collabora$(echo .)co.uk \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox