From: linux@roeck-us•net (Guenter Roeck)
To: linux-arm-kernel@lists•infradead.org
Subject: Fwd: [PATCH 3/8] watchdog: davinci: add GET_TIMELEFT option support
Date: Sat, 16 Nov 2013 18:22:02 -0800 [thread overview]
Message-ID: <5288284A.4020803@roeck-us.net> (raw)
In-Reply-To: <527A28AF.9040308@ti.com>
On 11/06/2013 03:31 AM, ivan.khoronzhuk wrote:
> Currently, the davinci watchdog can be read while counting,
> so we can add ability to report the remaining time before
> the system will reboot.
>
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti•com>
> ---
> drivers/watchdog/davinci_wdt.c | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/drivers/watchdog/davinci_wdt.c b/drivers/watchdog/davinci_wdt.c
> index 1fc2093..6cbf2e1 100644
> --- a/drivers/watchdog/davinci_wdt.c
> +++ b/drivers/watchdog/davinci_wdt.c
> @@ -117,6 +117,33 @@ static int davinci_wdt_ping(struct watchdog_device *wdd)
> return 0;
> }
>
> +static unsigned int davinci_wdt_get_timeleft(struct watchdog_device *wdd)
> +{
> + u64 timer_counter;
> + unsigned long freq;
> + u32 val;
> + struct davinci_wdt_device *davinci_wdt = watchdog_get_drvdata(wdd);
> +
> + /* if timeout is occured then return 0 */
is -> has ?
> + val = ioread32(davinci_wdt->base + WDTCR);
> + if (val & WDFLAG)
> + return 0;
> +
> + freq = clk_get_rate(davinci_wdt->clk);
> +
> + if (!freq) {
> + dev_err(wdd->dev, "clock freq is not set\n");
> + return 0;
> + }
> +
This error check doesn't make sense to me; elsewhere the clock rate is not validated.
I would suggest to just return 0 here.
> + timer_counter = ioread32(davinci_wdt->base + TIM12);
> + timer_counter |= ((u64)ioread32(davinci_wdt->base + TIM34) << 32);
> +
> + do_div(timer_counter, freq);
> +
> + return wdd->timeout - timer_counter;
> +}
> +
> static const struct watchdog_info davinci_wdt_info = {
> .options = WDIOF_KEEPALIVEPING,
> .identity = "DaVinci Watchdog",
> @@ -127,6 +154,7 @@ static const struct watchdog_ops davinci_wdt_ops = {
> .start = davinci_wdt_start,
> .stop = davinci_wdt_ping,
> .ping = davinci_wdt_ping,
> + .get_timeleft = davinci_wdt_get_timeleft,
> };
>
> static int davinci_wdt_probe(struct platform_device *pdev)
>
next prev parent reply other threads:[~2013-11-17 2:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1383680783-12114-4-git-send-email-ivan.khoronzhuk@ti.com>
2013-11-06 11:31 ` Fwd: [PATCH 3/8] watchdog: davinci: add GET_TIMELEFT option support ivan.khoronzhuk
2013-11-12 15:37 ` Santosh Shilimkar
2013-11-17 2:22 ` Guenter Roeck [this message]
2013-11-18 13:21 ` ivan.khoronzhuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5288284A.4020803@roeck-us.net \
--to=linux@roeck-us$(echo .)net \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox