From: florian.meier@koalo•de (Florian Meier)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCHv7] dmaengine: Add support for BCM2835
Date: Mon, 18 Nov 2013 15:37:01 +0100 [thread overview]
Message-ID: <528A260D.7090807@koalo.de> (raw)
In-Reply-To: <1384785017.14845.214.camel@smile>
>>>> +static enum dma_status bcm2835_dma_tx_status(struct dma_chan *chan,
>>>> + dma_cookie_t cookie, struct dma_tx_state *txstate)
>>>> +{
>>>
>>> []
>>>
>>>> + } else {
>>>> + txstate->residue = 0;
>>>
>>> Useless assignment since dmaengine will do this for you in
>>> dma_cookie_status.
>>
>> I agree that it is useless, but I think otherwise it might be concealed
>> that there is a third case left that uses a residue of 0. Do you think a
>> comment is better? E.g.:
>>
>> + } else {
>> + /* residue = 0 per default */
>
> I think like in many other DMA drivers either you have separate function
> to get residue, which returns 0, or just not include this case.
You mean like in the omap-dma.c? ;-P
>>>> +static int bcm2835_dma_probe(struct platform_device *pdev)
>>>> +{
>
>>>> + uint32_t chans_available;
>>>
>>> Why uint32_t?
>>
>> Because it is a bit mask of fixed length that directly comes from the
>> firmware.
>
> Like one already told you in your i2s patch, please, change that to
> corresponding u* value, namely u32.
I have no problem with changing that, but why?
next prev parent reply other threads:[~2013-11-18 14:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-17 15:39 [PATCHv7] dmaengine: Add support for BCM2835 Florian Meier
2013-11-17 16:02 ` Joe Perches
2013-11-17 16:37 ` Florian Meier
2013-11-17 20:12 ` [PATCH] mmp_pdma: Style neatening Joe Perches
2013-11-28 9:34 ` Vinod Koul
2013-11-18 10:00 ` [PATCHv7] dmaengine: Add support for BCM2835 Shevchenko, Andriy
2013-11-18 12:16 ` Florian Meier
2013-11-18 14:30 ` Andy Shevchenko
2013-11-18 14:37 ` Florian Meier [this message]
2013-11-18 14:54 ` Russell King - ARM Linux
2013-11-18 15:04 ` Mark Rutland
2013-11-18 22:18 ` Joe Perches
2013-11-18 14:41 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528A260D.7090807@koalo.de \
--to=florian.meier@koalo$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox