From: kishon@ti•com (Kishon Vijay Abraham I)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 1/9] phy: add phy_get_bus_width()/phy_set_bus_width() calls
Date: Tue, 26 Nov 2013 15:46:26 +0530 [thread overview]
Message-ID: <529474FA.9080103@ti.com> (raw)
In-Reply-To: <1385403367-18144-2-git-send-email-matt.porter@linaro.org>
Hi,
On Monday 25 November 2013 11:45 PM, Matt Porter wrote:
> This adds a pair of APIs that allows the generic PHY subsystem to
> provide information on the PHY bus width. The PHY provider driver may
> use phy_set_bus_width() to set the bus width that the PHY supports.
> The controller driver may then use phy_get_bus_width() to fetch the
> PHY bus width in order to properly configure the controller.
>
> Signed-off-by: Matt Porter <matt.porter@linaro•org>
> ---
> include/linux/phy/phy.h | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h
> index 6d72269..6ca6c61 100644
> --- a/include/linux/phy/phy.h
> +++ b/include/linux/phy/phy.h
> @@ -46,6 +46,7 @@ struct phy_ops {
> * @mutex: mutex to protect phy_ops
> * @init_count: used to protect when the PHY is used by multiple consumers
> * @power_count: used to protect when the PHY is used by multiple consumers
> + * @bus_width: used to specify data width of the PHY bus
> */
> struct phy {
> struct device dev;
> @@ -55,6 +56,7 @@ struct phy {
> struct mutex mutex;
> int init_count;
> int power_count;
> + int bus_width;
the bus_width can be part of the attrs struct which you initially proposed.
Soon there will be requests for other attributes being added (e.g., speed).
> };
>
> /**
> @@ -127,6 +129,14 @@ int phy_init(struct phy *phy);
> int phy_exit(struct phy *phy);
> int phy_power_on(struct phy *phy);
> int phy_power_off(struct phy *phy);
> +static inline int phy_get_bus_width(struct phy *phy)
> +{
> + return phy->bus_width;
> +}
> +static inline void phy_set_bus_width(struct phy *phy, int bus_width)
u32 bus_width?
> +{
> + phy->bus_width = bus_width;
> +}
> struct phy *phy_get(struct device *dev, const char *string);
> struct phy *devm_phy_get(struct device *dev, const char *string);
> void phy_put(struct phy *phy);
> @@ -199,6 +209,16 @@ static inline int phy_power_off(struct phy *phy)
> return -ENOSYS;
> }
>
> +static inline int phy_get_bus_width(struct phy *phy)
> +{
> + return -ENOSYS;
> +}
> +
> +static inline void phy_set_bus_width(struct phy *phy, bus_width)
er.. has this been compile tested?
Thanks
Kishon
next prev parent reply other threads:[~2013-11-26 10:16 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 18:15 [PATCH v3 0/9] USB Device Controller support for BCM281xx Matt Porter
2013-11-25 18:15 ` [PATCH v3 1/9] phy: add phy_get_bus_width()/phy_set_bus_width() calls Matt Porter
2013-11-26 10:16 ` Kishon Vijay Abraham I [this message]
2013-11-27 16:55 ` Matt Porter
2013-11-25 18:16 ` [PATCH v3 2/9] staging: dwc2: update DT binding to add generic clock/phy properties Matt Porter
2013-11-26 10:19 ` Kishon Vijay Abraham I
2013-11-27 16:56 ` Matt Porter
2013-11-25 18:16 ` [PATCH v3 3/9] usb: gadget: s3c-hsotg: enable build for other platforms Matt Porter
2013-11-25 18:16 ` [PATCH v3 4/9] usb: gadget: s3c-hsotg: add snps, dwc2 compatible string Matt Porter
2013-11-25 18:16 ` [PATCH v3 5/9] usb: gadget: s3c-hsotg: use generic phy_init()/phy_exit() support Matt Porter
2013-11-26 10:23 ` Kishon Vijay Abraham I
2013-11-27 17:13 ` Matt Porter
2013-11-27 22:36 ` Matt Porter
2013-11-28 5:53 ` Kishon Vijay Abraham I
2013-11-28 16:41 ` Matt Porter
2013-11-28 17:02 ` Kamil Debski
2013-11-25 18:16 ` [PATCH v3 6/9] usb: gadget: s3c-hsotg: get phy bus width from phy subsystem Matt Porter
2013-11-26 10:28 ` Kishon Vijay Abraham I
2013-11-27 17:16 ` Matt Porter
2013-11-25 18:16 ` [PATCH v3 7/9] phy: add Broadcom Kona USB2 PHY DT binding Matt Porter
2013-11-26 10:31 ` Kishon Vijay Abraham I
2013-11-27 17:19 ` Matt Porter
2013-11-25 18:16 ` [PATCH v3 8/9] phy: add Broadcom Kona USB2 PHY driver Matt Porter
2013-11-27 8:51 ` Kishon Vijay Abraham I
2013-11-27 17:21 ` Matt Porter
2013-11-25 18:16 ` [PATCH v3 9/9] ARM: dts: add usb udc support to bcm281xx Matt Porter
2013-11-27 8:57 ` Kishon Vijay Abraham I
2013-11-27 17:24 ` Matt Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529474FA.9080103@ti.com \
--to=kishon@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox