From: masami.hiramatsu.pt@hitachi•com (Masami Hiramatsu)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 06/15] ARM: Disable jprobes test when built into thumb-mode kernel
Date: Wed, 27 Nov 2013 19:16:26 +0900 [thread overview]
Message-ID: <5295C67A.3070308@hitachi.com> (raw)
In-Reply-To: <1385520814-10663-7-git-send-email-dave.long@linaro.org>
(2013/11/27 11:53), David Long wrote:
> From: "Jon Medhurst (Tixy)" <tixy@linaro•org>
>
> For now the jprobes tests fail on ARM for when built into a kernel compiled
> in thumb mode. They work fine for ARM kernels, and when built as a loadable
> module.
>
> Signed-off-by: David A. Long <dave.long@linaro•org>
You'd better add Jon's signed-off-by here.
Reviewed-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi•com>
> ---
> arch/arm/kernel/kprobes-test.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/kernel/kprobes-test.c b/arch/arm/kernel/kprobes-test.c
> index 0cd63d0..65230b2 100644
> --- a/arch/arm/kernel/kprobes-test.c
> +++ b/arch/arm/kernel/kprobes-test.c
> @@ -221,6 +221,7 @@ static int pre_handler_called;
> static int post_handler_called;
> static int jprobe_func_called;
> static int kretprobe_handler_called;
> +static int tests_failed;
>
> #define FUNC_ARG1 0x12345678
> #define FUNC_ARG2 0xabcdef
> @@ -457,6 +458,13 @@ static int run_api_tests(long (*func)(long, long))
>
> pr_info(" jprobe\n");
> ret = test_jprobe(func);
> +#if defined(CONFIG_THUMB2_KERNEL) && !defined(MODULE)
> + if (ret == -EINVAL) {
> + pr_err("FAIL: Known longtime bug with jprobe on Thumb kernels");
> + tests_failed = ret;
> + ret = 0;
> + }
> +#endif
> if (ret < 0)
> return ret;
>
> @@ -1667,6 +1675,8 @@ static int __init run_all_tests(void)
>
> out:
> if (ret == 0)
> + ret = tests_failed;
> + if (ret == 0)
> pr_info("Finished kprobe tests OK\n");
> else
> pr_err("kprobe tests failed\n");
>
--
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt at hitachi.com
next prev parent reply other threads:[~2013-11-27 10:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 2:53 [PATCH v3 00/15] uprobes: Add uprobes support for ARM David Long
2013-11-27 2:53 ` [PATCH v3 01/15] uprobes: allow ignoring of probe hits David Long
2013-11-28 18:41 ` Oleg Nesterov
2013-11-27 2:53 ` [PATCH v3 02/15] ARM: move shared uprobe/kprobe definitions into new include file David Long
2013-11-27 2:53 ` [PATCH v3 03/15] ARM: Move generic arm instruction parsing code to new files for sharing between features David Long
2013-11-27 2:53 ` [PATCH v3 04/15] ARM: move generic thumb instruction parsing code to new files for use by other feature David Long
2013-11-27 2:53 ` [PATCH v3 05/15] ARM: use a function table for determining instruction interpreter actions David Long
2013-11-27 2:53 ` [PATCH v3 06/15] ARM: Disable jprobes test when built into thumb-mode kernel David Long
2013-11-27 10:16 ` Masami Hiramatsu [this message]
2013-11-27 10:41 ` Jon Medhurst (Tixy)
2013-11-27 2:53 ` [PATCH v3 07/15] ARM: Remove use of struct kprobe from generic probes code David Long
2013-11-27 2:53 ` [PATCH v3 08/15] ARM: Use new opcode type in ARM kprobes/uprobes code David Long
2013-11-27 2:53 ` [PATCH v3 09/15] ARM: Make the kprobes condition_check symbol names more generic David Long
2013-11-27 2:53 ` [PATCH v3 10/15] ARM: Change more ARM kprobes symbol names to something more David Long
2013-11-27 2:53 ` [PATCH v3 11/15] ARM: Rename the shared kprobes/uprobe return value enum David Long
2013-11-27 2:53 ` [PATCH v3 12/15] ARM: Change the remaining shared kprobes/uprobes symbols to something generic David Long
2013-11-27 2:53 ` [PATCH v3 13/15] ARM: Add an emulate flag to the kprobes/uprobes instruction decode functions David Long
2013-11-27 2:53 ` [PATCH v3 14/15] ARM: add uprobes support David Long
2013-12-04 17:23 ` Taras Kondratiuk
2013-11-27 2:53 ` [PATCH v3 15/15] ARM: Remove uprobes dependency on kprobes David Long
2013-12-04 17:51 ` [PATCH v3 00/15] uprobes: Add uprobes support for ARM Taras Kondratiuk
2013-12-05 19:48 ` David Long
2013-12-05 20:17 ` David Long
2013-12-20 16:10 ` Jon Medhurst (Tixy)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5295C67A.3070308@hitachi.com \
--to=masami.hiramatsu.pt@hitachi$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox