Subject: [PATCH 03/04] ARM: shmobile: Genmai I2C-over-GPIO support

From: [email-masked] (Sergei Shtylyov)
Date: Thu, 28 Nov 2013 21:11:48 +0400

Hello.

On 27-11-2013 15:04, Wolfram Sang wrote:

>> +		#address-cells = <1>;
>> +		#size-cells = <0>;
>> +
>> +		eeprom: 24c128 at 50 {
>> +			compatible = "at,24c128";

> Minor nit: Should be a vendor name, not the name of the driver

    Moreover, the node should be named generically, like "flash at 50", not 
"24c128 at 50".

WBR, Sergei