From: kishon@ti•com (Kishon Vijay Abraham I)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 1/7] usb: dwc3: get "usb_phy" only if the platform indicates the presence of PHY's
Date: Tue, 3 Dec 2013 15:20:39 +0530 [thread overview]
Message-ID: <529DA96F.3000903@ti.com> (raw)
In-Reply-To: <20131125213213.GV18046@saruman.home>
Hi,
On Tuesday 26 November 2013 03:02 AM, Felipe Balbi wrote:
> Hi,
>
> On Mon, Nov 11, 2013 at 08:06:12PM +0530, Kishon Vijay Abraham I wrote:
>>>> diff --git a/drivers/usb/dwc3/platform_data.h b/drivers/usb/dwc3/platform_data.h
>>>> index 7db34f0..49ffa6d 100644
>>>> --- a/drivers/usb/dwc3/platform_data.h
>>>> +++ b/drivers/usb/dwc3/platform_data.h
>>>> @@ -24,4 +24,6 @@ struct dwc3_platform_data {
>>>> enum usb_device_speed maximum_speed;
>>>> enum usb_dr_mode dr_mode;
>>>> bool tx_fifo_resize;
>>>> + bool usb2_phy;
>>>> + bool usb3_phy;
>>>
>>> This would look better as a quirks flag, then we could:
>>>
>>> unsigned long quirks;
>>> #define DWC3_QUIRK_NO_USB3_PHY BIT(0)
>>> #define DWC3_QUIRK_NO_USB2_PHY BIT(1)
>>
>> Should this quirk be used for dt also? Currently we find if it has usb3 phy or
>> usb2 phy from the dt data only. But if we add a quirk, we'll have to add a
>> property to populate the quirk no?
>
> either we use the quirk, or use the fact that no <&usb2_phy> phandle is
> defined, would work both ways, no ?
In my v3, I've made both to use quirks since we don't want to have separate
mechanism for dt and non-dt stuff to know the presence of a particular PHY.
Thanks
Kishon
next prev parent reply other threads:[~2013-12-03 9:50 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 19:54 [PATCH v2 0/7] Make dwc3 use Generic PHY Framework Kishon Vijay Abraham I
2013-10-15 19:54 ` [PATCH v2 1/7] usb: dwc3: get "usb_phy" only if the platform indicates the presence of PHY's Kishon Vijay Abraham I
2013-10-16 13:03 ` Roger Quadros
2013-10-16 13:10 ` Kishon Vijay Abraham I
2013-10-16 13:27 ` Roger Quadros
2013-10-17 14:54 ` Felipe Balbi
2013-12-03 10:39 ` Heikki Krogerus
2013-12-06 20:15 ` Felipe Balbi
2013-12-09 8:52 ` Heikki Krogerus
2013-12-12 18:27 ` Felipe Balbi
2013-11-05 18:11 ` Vivek Gautam
2013-11-05 18:12 ` Vivek Gautam
2013-10-17 16:38 ` Felipe Balbi
2013-10-21 11:56 ` Kishon Vijay Abraham I
2013-11-11 14:36 ` Kishon Vijay Abraham I
2013-11-25 21:32 ` Felipe Balbi
2013-12-03 9:50 ` Kishon Vijay Abraham I [this message]
2013-10-15 19:54 ` [PATCH v2 2/7] usb: dwc3: adapt dwc3 core to use Generic PHY Framework Kishon Vijay Abraham I
2013-10-16 13:18 ` Roger Quadros
2013-10-16 13:52 ` Kishon Vijay Abraham I
2013-10-16 14:23 ` Roger Quadros
2013-10-21 11:55 ` Kishon Vijay Abraham I
2013-10-21 12:13 ` Roger Quadros
2013-12-03 11:59 ` Heikki Krogerus
2013-12-03 14:13 ` Kishon Vijay Abraham I
2013-10-15 19:54 ` [PATCH v2 3/7] Documentation: dt bindings: move ..usb/usb-phy.txt to ..phy/ti-phy.txt Kishon Vijay Abraham I
2013-10-15 19:54 ` [PATCH v2 4/7] drivers: phy: usb3/pipe3: Adapt pipe3 driver to Generic PHY Framework Kishon Vijay Abraham I
2013-10-16 13:40 ` Roger Quadros
2013-10-21 12:53 ` Kishon Vijay Abraham I
2013-10-15 19:54 ` [PATCH v2 5/7] usb: phy: omap-usb2: remove *set_suspend* callback from omap-usb2 Kishon Vijay Abraham I
2013-10-15 19:54 ` [PATCH v2 6/7] phy: omap-usb2: move omap_usb.h from linux/usb/ to linux/phy/ Kishon Vijay Abraham I
2013-10-15 19:54 ` [PATCH v2 7/7] arm/dts: added dt properties to adapt to the new phy framwork Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529DA96F.3000903@ti.com \
--to=kishon@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox