From: nsekhar@ti•com (Sekhar Nori)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v4 1/5] watchdog: davinci: change driver to use WDT core
Date: Wed, 4 Dec 2013 23:34:46 +0530 [thread overview]
Message-ID: <529F6EBE.5050703@ti.com> (raw)
In-Reply-To: <1385556508-3935-2-git-send-email-ivan.khoronzhuk@ti.com>
On 11/27/2013 6:18 PM, Ivan Khoronzhuk wrote:
> To reduce code duplicate and increase code readability use WDT core
> code to handle WDT interface.
>
> Remove io_lock as the WDT core uses mutex to lock each wdt device.
> Remove wdt_state as the WDT core tracks state with its own variable.
>
> The watchdog_init_timeout() can read timeout value from timeout-sec
> property if the passed value is out of bounds. The heartbeat is
> initialized in next way. If heartbeat is not set thought module
> parameter, try to read it's value from WDT node timeout-sec property.
> If node has no one, use default value.
>
> The heartbeat is hold in wdd->timeout by WDT core, so use it in
> order to set timeout period.
>
> Acked-by: Santosh Shilimkar <santosh.shilimkar@ti•com>
> Reviewed-by: Guenter Roeck <linux@roeck-us•net>
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti•com>
> ---
> drivers/watchdog/Kconfig | 2 +
> drivers/watchdog/davinci_wdt.c | 147 ++++++++++------------------------------
> 2 files changed, 37 insertions(+), 112 deletions(-)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 5be6e91..eb8c89d 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -271,6 +271,8 @@ config IOP_WATCHDOG
> config DAVINCI_WATCHDOG
> tristate "DaVinci watchdog"
> depends on ARCH_DAVINCI
> + select WATCHDOG_CORE
> + select WATCHDOG_NOWAYOUT
Its not clear for change log why NOWAYOUT needs to be forced on all the
time for all users of DaVinci watchdog.
Thanks,
Sekhar
next prev parent reply other threads:[~2013-12-04 18:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 12:48 [PATCH v4 0/5] Update Davinci watchdog driver Ivan Khoronzhuk
2013-11-27 12:48 ` [PATCH v4 1/5] watchdog: davinci: change driver to use WDT core Ivan Khoronzhuk
2013-12-04 18:04 ` Sekhar Nori [this message]
2013-12-04 18:28 ` Guenter Roeck
2013-12-04 18:42 ` ivan.khoronzhuk
2013-12-04 18:58 ` Guenter Roeck
2013-12-04 19:06 ` ivan.khoronzhuk
2013-11-27 12:48 ` [PATCH v4 2/5] watchdog: davinci: use davinci_wdt_device structure to hold device data Ivan Khoronzhuk
2013-11-27 12:48 ` [PATCH v4 3/5] watchdog: davinci: add GET_TIMELEFT option support Ivan Khoronzhuk
2013-11-27 12:48 ` [PATCH v4 4/5] watchdog: davinci: add "timeout-sec" property Ivan Khoronzhuk
2013-11-27 12:48 ` [PATCH v4 5/5] watchdog: davinci: reuse driver for keystone arch Ivan Khoronzhuk
2013-11-29 13:18 ` [PATCH v4 0/5] Update Davinci watchdog driver Grygorii Strashko
2013-11-29 14:57 ` Santosh Shilimkar
2013-12-04 18:10 ` Sekhar Nori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529F6EBE.5050703@ti.com \
--to=nsekhar@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox