From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/4] ARM: tegra: add I2C controllers to Tegra124 DT
Date: Fri, 06 Dec 2013 10:36:57 -0700 [thread overview]
Message-ID: <52A20B39.7010703@wwwdotorg.org> (raw)
In-Reply-To: <20131206140333.GE30960@ulmo.nvidia.com>
On 12/06/2013 07:03 AM, Thierry Reding wrote:
> On Wed, Dec 04, 2013 at 03:26:53PM -0700, Stephen Warren wrote:
> [...]
>> diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi
> [...]
>> @@ -176,6 +176,96 @@
>> status = "disabled";
>> };
>>
>> + i2c at 7000c000 {
>> + compatible = "nvidia,tegra114-i2c";
>
> Aren't we supposed to always list the most specific compatible as well,
> just in case we ever need to implement a specific quirk in the future?
>
> So this would become:
>
> compatible = "nvidia,tegra124-i2c", "nvidia,tegra114-i2c";
Oops yes, I'll fix that up.
next prev parent reply other threads:[~2013-12-06 17:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 22:26 [PATCH 1/4] ARM: tegra: add I2C controllers to Tegra124 DT Stephen Warren
2013-12-04 22:26 ` [PATCH 2/4] ARM: tegra: enable I2C controllers on Venice2 Stephen Warren
2013-12-06 15:20 ` Thierry Reding
2013-12-06 17:42 ` Stephen Warren
2013-12-04 22:26 ` [PATCH 3/4] ARM: tegra: add audio-related device to Tegra124 DT Stephen Warren
2013-12-04 22:26 ` [PATCH 4/4] ARM: tegra: add sound card to Venice2 DT Stephen Warren
2013-12-06 14:03 ` [PATCH 1/4] ARM: tegra: add I2C controllers to Tegra124 DT Thierry Reding
2013-12-06 17:36 ` Stephen Warren [this message]
2013-12-12 19:44 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A20B39.7010703@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox