From: sergei.shtylyov@cogentembedded•com (Sergei Shtylyov)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] net: allwinner: emac: Add missing free_irq
Date: Sat, 07 Dec 2013 20:57:05 +0400 [thread overview]
Message-ID: <52A35361.8090608@cogentembedded.com> (raw)
In-Reply-To: <1386415902-32697-1-git-send-email-maxime.ripard@free-electrons.com>
Hello.
On 07-12-2013 15:31, Maxime Ripard wrote:
> The sun4i-emac driver uses devm_request_irq at .ndo_open time, but relies on
> the managed device mechanism to actually free it. This causes an issue whenever
> someone wants to restart the interface, the interrupt still being held, and not
> yet released.
> Fall back to using the regular request_irq at .ndo_open time, and introduce a
> free_irq during .ndo_stop.
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons•com>
> ---
> Hi David,
> It would be great if this patch would be applied to 3.13.
> Thanks,
> Maxime
> drivers/net/ethernet/allwinner/sun4i-emac.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
> diff --git a/drivers/net/ethernet/allwinner/sun4i-emac.c b/drivers/net/ethernet/allwinner/sun4i-emac.c
> index 50b853a..38aba50 100644
> --- a/drivers/net/ethernet/allwinner/sun4i-emac.c
> +++ b/drivers/net/ethernet/allwinner/sun4i-emac.c
> @@ -717,8 +717,8 @@ static int emac_open(struct net_device *dev)
> if (netif_msg_ifup(db))
> dev_dbg(db->dev, "enabling %s\n", dev->name);
>
> - if (devm_request_irq(db->dev, dev->irq, &emac_interrupt,
> - 0, dev->name, dev))
> + if (request_irq(dev->irq, &emac_interrupt,
> + 0, dev->name, dev))
Doesn't it fit into single line?
WBR, Sergei
next prev parent reply other threads:[~2013-12-07 16:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-07 11:31 [PATCH] net: allwinner: emac: Add missing free_irq Maxime Ripard
2013-12-07 16:57 ` Sergei Shtylyov [this message]
2013-12-10 17:52 ` Maxime Ripard
-- strict thread matches above, loose matches on Subject: below --
2014-06-23 20:49 Maxime Ripard
2014-06-25 23:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A35361.8090608@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox