public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: ivan.khoronzhuk@ti•com (ivan.khoronzhuk)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3] ARM: davinci: aemif: get rid of davinci-nand driver dependency on aemif
Date: Mon, 9 Dec 2013 10:58:27 +0200	[thread overview]
Message-ID: <52A58633.7060705@ti.com> (raw)
In-Reply-To: <52A23BE0.2000207@ti.com>

On 12/06/2013 11:04 PM, Sekhar Nori wrote:
> On 12/5/2013 11:41 PM, Ivan Khoronzhuk wrote:
> 
>> diff --git a/arch/arm/mach-davinci/board-mityomapl138.c b/arch/arm/mach-davinci/board-mityomapl138.c
>> index 7aa105b..98a66ff 100644
>> --- a/arch/arm/mach-davinci/board-mityomapl138.c
>> +++ b/arch/arm/mach-davinci/board-mityomapl138.c
>> @@ -432,6 +432,9 @@ static void __init mityomapl138_setup_nand(void)
>>   {
>>   	platform_add_devices(mityomapl138_devices,
>>   				 ARRAY_SIZE(mityomapl138_devices));
>> +
>> +	if (davinci_aemif_setup(&mityomapl138_nandflash_device))
>> +		pr_warn("%s: Cannot configure AEMIF.\n", __func__);
>>   }
> 
> I must be missing something, but exactly why is this required for
> board-mityomapl138.c?
> 
> Thanks,
> Sekhar
> 

board-mityomapl138.c - only one board file with NAND_BUSWIDTH_16 option set in pdata.
By default bus width is treated as 8 bit, in another case we have to set it.
Currently bus width setup is done in davinci_aemif_setup(). So, to set bus width
correctly we have to call davinci_aemif_setup() for board in question.

-- 
Regards,
Ivan Khoronzhuk

  reply	other threads:[~2013-12-09  8:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-05 18:11 [PATCH v3] ARM: davinci: aemif: get rid of davinci-nand driver dependency on aemif Ivan Khoronzhuk
2013-12-06 21:04 ` Sekhar Nori
2013-12-09  8:58   ` ivan.khoronzhuk [this message]
2013-12-18 11:51 ` ivan.khoronzhuk
2013-12-18 12:13   ` Sekhar Nori
2013-12-26 12:06     ` ivan.khoronzhuk
2014-01-09 10:39       ` Sekhar Nori
2014-01-09 16:33         ` Brian Norris
2014-01-10  4:19           ` Sekhar Nori
2014-01-10  7:15           ` Sekhar Nori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52A58633.7060705@ti.com \
    --to=ivan.khoronzhuk@ti$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox