From: marc.zyngier@arm•com (Marc Zyngier)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/2] ARM/ARM64: KVM: Forward PSCI SYSTEM_OFF and SYSTEM_RESET to user space
Date: Tue, 10 Dec 2013 10:57:17 +0000 [thread overview]
Message-ID: <52A6F38D.4000109@arm.com> (raw)
In-Reply-To: <CAAhSdy2zM49tOon9x41JNbw4w_UROXNm1pFE0ku_whs+LddhWA@mail.gmail.com>
On 10/12/13 05:05, Anup Patel wrote:
> On Tue, Dec 10, 2013 at 4:21 AM, Christoffer Dall
> <christoffer.dall@linaro•org> wrote:
>> On Mon, Nov 25, 2013 at 09:19:59PM +0530, Anup Patel wrote:
>>> @@ -39,9 +44,6 @@ static int handle_hvc(struct kvm_vcpu *vcpu, struct kvm_run *run)
>>>
>>> static int handle_smc(struct kvm_vcpu *vcpu, struct kvm_run *run)
>>> {
>>> - if (kvm_psci_call(vcpu))
>>> - return 1;
>>> -
>>
>> Isn't this an unrelated change, which should go in a separate patch with
>> some justification text for the change?
>
> Actually, handle_smc() was already using kvm_psci_call() so I had to change
> it anyway because of changes in kvm_psic_call(). Also, user space emulation
> of SMC-based PSCI is going to be different from in-kernel HVC-based PSCI
> emulation hence, for now it seemed more appropriate to inject undefined
> exception for KVM arm64 (just like KVM arm).
Doh. I though I got rid of that.
That chunk should have been been removed ages ago (probably before
merging the arm64 code), as per 24a7f6757.
Please make it a separate patch, and I'll merge that independently.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2013-12-10 10:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 15:49 [PATCH 0/2] PSCI system off and reset for KVM ARM/ARM64 Anup Patel
2013-11-25 15:49 ` [PATCH 1/2] KVM: Add KVM_EXIT_RESET to user space API header Anup Patel
2013-11-26 3:59 ` Anup Patel
2013-12-09 22:52 ` Christoffer Dall
2013-12-10 2:13 ` Alexander Graf
2013-12-10 4:23 ` Anup Patel
2013-12-10 15:49 ` Alexander Graf
2013-12-10 16:07 ` Anup Patel
2013-12-10 16:45 ` Alexander Graf
2013-12-10 22:32 ` Christoffer Dall
2013-12-10 22:30 ` Christoffer Dall
2013-12-10 22:34 ` Alexander Graf
2013-12-10 22:27 ` Christoffer Dall
2013-12-10 22:36 ` Alexander Graf
2013-12-11 4:30 ` Anup Patel
2013-11-25 15:49 ` [PATCH 2/2] ARM/ARM64: KVM: Forward PSCI SYSTEM_OFF and SYSTEM_RESET to user space Anup Patel
2013-11-26 3:59 ` Anup Patel
2013-12-09 22:51 ` Christoffer Dall
2013-12-10 5:05 ` Anup Patel
2013-12-10 10:57 ` Marc Zyngier [this message]
2013-12-10 15:31 ` Anup Patel
2013-11-25 15:57 ` [PATCH 0/2] PSCI system off and reset for KVM ARM/ARM64 Anup Patel
2013-11-26 4:00 ` Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A6F38D.4000109@arm.com \
--to=marc.zyngier@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox