From: sergei.shtylyov@cogentembedded•com (Sergei Shtylyov)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 07/15] mmc: sdhi: Enable driver compilation with COMPILE_TEST
Date: Wed, 11 Dec 2013 22:01:53 +0400 [thread overview]
Message-ID: <52A8A891.40302@cogentembedded.com> (raw)
In-Reply-To: <1385515117-23664-8-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
Hello.
On 27-11-2013 5:18, Laurent Pinchart wrote:
> This helps increasing build testing coverage.
> The driver doesn't compile on (at least) x86 due (possibly among others)
> to missing readsw/writesw I/O accessors, restrict compilation to SUPERH
> or ARM.
> Whether the CTL_DMA_ENABLE register is part of the standard TMIO
> controller or is Renesas-specific is unknown and impossible to test as
> we have no current or planned TMIO DMA users other than SUPERH and
> ARCH_SHMOBILE. Writing to the register is thus conditionally compiled
> for SUPERH and ARCH_SHMOBILE only. Adding ARCH_SHMOBILE_MULTI to the
> list would extend this to multiarch kernels, but would break the driver
> for non-shmobile platforms if the register is Renesas-specific. We can
> thus get rid of the conditional compilation completely without
> introducing any further issue, and let future non-Renesas users deal
> with the situation if it turns out to be a the problem.
> Cc: Chris Ball <cjb@laptop•org>
> Cc: Guennadi Liakhovetski <g.liakhovetski@gmx•de>
> Cc: Ian Molton <ian@mnementh•co.uk>
> Cc: linux-mmc at vger.kernel.org
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard•com>
> Acked-by: Simon Horman <horms@verge•net.au>
> ---
> drivers/mmc/host/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 7fc5099..ca1315e 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -479,7 +479,8 @@ config MMC_TMIO
>
> config MMC_SDHI
> tristate "SH-Mobile SDHI SD/SDIO controller support"
> - depends on SUPERH || ARCH_SHMOBILE
> + depends on SUPERH || ARM
> + depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
Hm, why 2 "depends" lines with SUPERH in both?
WBR, Sergei
next prev parent reply other threads:[~2013-12-11 18:01 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 1:18 [PATCH 00/15] Enable compilation of various Renesas drivers with COMPILE_TEST Laurent Pinchart
2013-11-27 1:18 ` [PATCH 01/15] i2c: shmobile/rcar: Restrict non-COMPILE_TEST compilation Laurent Pinchart
2013-11-28 7:36 ` Simon Horman
2013-12-11 12:47 ` Laurent Pinchart
2014-01-02 15:05 ` Laurent Pinchart
2014-01-03 15:47 ` Wolfram Sang
2013-11-27 1:18 ` [PATCH 02/15] input: sh_keysc: " Laurent Pinchart
2013-11-28 7:36 ` Simon Horman
2013-12-06 3:20 ` Dmitry Torokhov
2013-11-27 1:18 ` [PATCH 03/15] serial: sh-sci: " Laurent Pinchart
2013-11-28 7:37 ` Simon Horman
2013-12-11 12:44 ` Laurent Pinchart
2013-12-24 12:03 ` Laurent Pinchart
2013-12-24 14:26 ` Simon Horman
2013-12-27 2:17 ` Simon Horman
2013-12-03 18:45 ` Greg Kroah-Hartman
2013-11-27 1:18 ` [PATCH 04/15] iommu: shmobile: Enable driver compilation with COMPILE_TEST Laurent Pinchart
2013-11-28 7:36 ` Simon Horman
2013-12-11 12:48 ` Laurent Pinchart
2014-01-07 14:11 ` Joerg Roedel
2013-11-27 1:18 ` [PATCH 05/15] DMA: shdma: " Laurent Pinchart
2013-12-11 12:48 ` Laurent Pinchart
2013-11-27 1:18 ` [PATCH 06/15] v4l: sh_vou: " Laurent Pinchart
2013-12-11 12:46 ` Laurent Pinchart
2013-11-27 1:18 ` [PATCH 07/15] mmc: sdhi: " Laurent Pinchart
2013-12-11 12:53 ` Laurent Pinchart
2014-01-07 15:10 ` Laurent Pinchart
2014-01-07 15:50 ` Chris Ball
2014-01-07 16:13 ` Laurent Pinchart
2013-12-11 18:01 ` Sergei Shtylyov [this message]
2013-12-11 18:06 ` Laurent Pinchart
2013-12-11 18:22 ` Sergei Shtylyov
2013-12-11 23:05 ` Laurent Pinchart
2013-11-27 1:18 ` [PATCH 08/15] mmc: sh_mmcif: " Laurent Pinchart
2013-11-27 1:18 ` [PATCH 09/15] mtd: sh_flctl: " Laurent Pinchart
2013-12-11 12:48 ` Laurent Pinchart
2013-12-13 18:19 ` Brian Norris
2013-11-27 1:18 ` [PATCH 10/15] irda: sh_irda: " Laurent Pinchart
2013-12-11 12:49 ` Laurent Pinchart
2014-01-07 15:13 ` Laurent Pinchart
2014-03-04 18:19 ` Laurent Pinchart
2013-11-27 1:18 ` [PATCH 11/15] pwm: pwm-renesas-tpu: " Laurent Pinchart
2013-11-29 10:53 ` Thierry Reding
2013-11-29 13:51 ` Laurent Pinchart
2013-12-11 12:49 ` Laurent Pinchart
2013-12-12 12:37 ` Thierry Reding
2013-11-27 1:18 ` [PATCH 12/15] thermal: rcar-thermal: " Laurent Pinchart
2013-12-11 12:50 ` Laurent Pinchart
2013-12-12 14:01 ` Eduardo Valentin
2014-01-02 2:55 ` Zhang Rui
2013-11-27 1:18 ` [PATCH 13/15] fbdev: sh-mobile-lcdcfb: " Laurent Pinchart
2013-12-11 12:51 ` Laurent Pinchart
2014-01-07 15:15 ` Laurent Pinchart
2014-01-08 8:30 ` Tomi Valkeinen
2014-01-17 9:00 ` Tomi Valkeinen
2014-01-19 21:01 ` Laurent Pinchart
2014-01-20 11:21 ` Tomi Valkeinen
2014-01-20 15:30 ` Laurent Pinchart
2013-11-27 1:18 ` [PATCH 14/15] spi: sh-msiof: " Laurent Pinchart
2013-11-27 16:35 ` Mark Brown
2013-11-27 1:18 ` [PATCH 15/15] sh: intc: " Laurent Pinchart
2013-12-11 12:52 ` Laurent Pinchart
2014-01-07 9:54 ` Laurent Pinchart
2014-01-08 4:35 ` Simon Horman
2014-02-18 0:26 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A8A891.40302@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox