From: ivan.khoronzhuk@ti•com (ivan.khoronzhuk)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 1/9] mtd: nand: davinci: fix driver registration
Date: Tue, 17 Dec 2013 12:21:12 +0200 [thread overview]
Message-ID: <52B02598.5060004@ti.com> (raw)
In-Reply-To: <20131217092449.GL12034@norris-Latitude-E6410>
On 12/17/2013 11:24 AM, Brian Norris wrote:
> On Thu, Dec 05, 2013 at 07:25:49PM +0200, Ivan Khoronzhuk wrote:
>> --- a/drivers/mtd/nand/davinci_nand.c
>> +++ b/drivers/mtd/nand/davinci_nand.c
>> @@ -877,6 +877,7 @@ static int __exit nand_davinci_remove(struct platform_device *pdev)
>> }
>>
>> static struct platform_driver nand_davinci_driver = {
>> + .probe = nand_davinci_probe,
>> .remove = __exit_p(nand_davinci_remove),
>
> I believe you need to drop the __exit_p() here. And now that you're
> using module_platform_driver(), you need to drop the __init and __exit
> from the probe() and remove() routines, to avoid section mismatch
> warnings.
>
>> .driver = {
>> .name = "davinci_nand",
>
> So on second thought, please resubmit the series with the requested
> changes.
>
> Thanks,
> Brian
>
Thanks, Brian.
Do you want me to drop it in stand alone patch or in this one?
--
Regards,
Ivan Khoronzhuk
next prev parent reply other threads:[~2013-12-17 10:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 17:25 [PATCH v3 0/9] Reuse davinci-nand driver for Keystone arch Ivan Khoronzhuk
2013-12-05 17:25 ` [PATCH v3 1/9] mtd: nand: davinci: fix driver registration Ivan Khoronzhuk
2013-12-17 9:24 ` Brian Norris
2013-12-17 10:21 ` ivan.khoronzhuk [this message]
2013-12-17 10:43 ` Brian Norris
2013-12-05 17:25 ` [PATCH v3 2/9] mtd: nand: davinci: return ENOMEM if memory allocation is failed Ivan Khoronzhuk
2013-12-05 17:25 ` [PATCH v3 3/9] mtd: nand: davinci: check required ti, davinci-chipselect property Ivan Khoronzhuk
2013-12-05 17:25 ` [PATCH v3 4/9] mtd: nand: davinci: simplify error handling Ivan Khoronzhuk
2013-12-05 17:25 ` [PATCH v3 5/9] mtd: nand: davinci: move bindings under mtd Ivan Khoronzhuk
2013-12-05 17:25 ` [PATCH v3 6/9] mtd: nand: davinci: extend description of bindings Ivan Khoronzhuk
2013-12-05 17:25 ` [PATCH v3 7/9] mtd: nand: davinci: adjust DT properties to MTD generic Ivan Khoronzhuk
2013-12-17 8:50 ` Brian Norris
2013-12-17 12:19 ` ivan.khoronzhuk
2013-12-05 17:25 ` [PATCH v3 8/9] mtd: nand: davinci: reuse driver for Keystone arch Ivan Khoronzhuk
2013-12-05 17:25 ` [PATCH v3 9/9] mtd: nand: davinci: don't request AEMIF address range Ivan Khoronzhuk
2013-12-17 8:42 ` Brian Norris
2013-12-17 10:33 ` ivan.khoronzhuk
2013-12-09 16:44 ` [PATCH v3 0/9] Reuse davinci-nand driver for Keystone arch Santosh Shilimkar
2013-12-14 19:18 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B02598.5060004@ti.com \
--to=ivan.khoronzhuk@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox