From: kishon@ti•com (Kishon Vijay Abraham I)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v7 8/9] phy: add Broadcom Kona USB2 PHY driver
Date: Thu, 19 Dec 2013 11:19:35 +0530 [thread overview]
Message-ID: <52B288EF.1040006@ti.com> (raw)
In-Reply-To: <20131218162554.GF4970@saruman.home>
Hi Felipe,
On Wednesday 18 December 2013 09:55 PM, Felipe Balbi wrote:
> On Tue, Dec 17, 2013 at 02:42:35PM -0500, Matt Porter wrote:
>> Add a driver for the internal Broadcom Kona USB 2.0 PHY found
>> on the BCM281xx family of SoCs.
>>
>> Signed-off-by: Matt Porter <mporter@linaro•org>
>
> Kishon, are you ok with this driver ?
yeah. Since this patch touches phy/Kconfig (and Makefile) and there is one more
PHY driver to be merged that also modifies Kconfig there might be conflicts. So
thought I should be taking this patch?
>
>> +static int bcm_kona_usb2_probe(struct platform_device *pdev)
>> +{
>> + struct device *dev = &pdev->dev;
>> + struct bcm_kona_usb *phy;
>> + struct resource *res;
>> + struct phy *gphy;
>> + struct phy_provider *phy_provider;
>> +
>> + phy = devm_kzalloc(dev, sizeof(*phy), GFP_KERNEL);
>> + if (!phy)
>> + return -ENOMEM;
>> +
>> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> + phy->regs = devm_ioremap_resource(&pdev->dev, res);
>> + if (IS_ERR(phy->regs))
>> + return PTR_ERR(phy->regs);
>> +
>> + platform_set_drvdata(pdev, phy);
>> +
>> + phy_provider = devm_of_phy_provider_register(dev,
>> + of_phy_simple_xlate);
>> + if (IS_ERR(phy_provider))
>> + return PTR_ERR(phy_provider);
>> +
>> + gphy = devm_phy_create(dev, &ops, NULL);
>> + if (IS_ERR(gphy))
>> + return PTR_ERR(gphy);
>> +
>> + /* The Kona PHY supports an 8-bit wide UTMI interface */
>> + phy_set_bus_width(gphy, 8);
>> +
>> + phy_set_drvdata(gphy, phy);
>
> I think this set_drvdata() should be done before registering the
> provider, no ?
hmm, right.
Thanks
Kishon
next prev parent reply other threads:[~2013-12-19 5:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 19:42 [PATCH v7 0/9] USB Device Controller support for BCM281xx Matt Porter
2013-12-17 19:42 ` [PATCH v7 1/9] phy: add phy_get_bus_width()/phy_set_bus_width() calls Matt Porter
2013-12-17 19:42 ` [PATCH v7 2/9] staging: dwc2: update DT binding to add generic clock/phy properties Matt Porter
2013-12-17 19:42 ` [PATCH v7 3/9] usb: gadget: s3c-hsotg: enable build for other platforms Matt Porter
2013-12-17 19:42 ` [PATCH v7 4/9] usb: gadget: s3c-hsotg: add snps, dwc2 compatible string Matt Porter
2013-12-17 19:42 ` [PATCH v7 5/9] usb: gadget: s3c-hsotg: enable generic phy support Matt Porter
2013-12-17 19:42 ` [PATCH v7 6/9] usb: gadget: s3c-hsotg: get phy bus width from phy subsystem Matt Porter
2013-12-17 19:42 ` [PATCH v7 7/9] phy: add Broadcom Kona USB2 PHY DT binding Matt Porter
2013-12-17 19:42 ` [PATCH v7 8/9] phy: add Broadcom Kona USB2 PHY driver Matt Porter
2013-12-18 16:25 ` Felipe Balbi
2013-12-18 17:15 ` Matt Porter
2013-12-19 5:49 ` Kishon Vijay Abraham I [this message]
2013-12-19 14:25 ` Matt Porter
2013-12-19 14:33 ` Felipe Balbi
2013-12-17 19:42 ` [PATCH v7 9/9] ARM: dts: add usb udc support to bcm281xx Matt Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B288EF.1040006@ti.com \
--to=kishon@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox