From: leoy@marvell•com (Leo Yan)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH RFC v3 04/12] arm64: kernel: cpu_{suspend/resume} implementation
Date: Fri, 20 Dec 2013 19:30:16 +0800 [thread overview]
Message-ID: <52B42A48.5090202@marvell.com> (raw)
In-Reply-To: <1385033059-25896-5-git-send-email-lorenzo.pieralisi@arm.com>
On 11/21/2013 07:24 PM, Lorenzo Pieralisi wrote:
> +/*
> + * x0 must contain the sctlr value retrieved from restored context
> + */
> +ENTRY(cpu_resume_mmu)
> + ldr x3, =cpu_resume_after_mmu
> + msr sctlr_el1, x0 // restore sctlr_el1
> + isb
> + br x3 // global jump to virtual address
> +ENDPROC(cpu_resume_mmu)
> +cpu_resume_after_mmu:
> + mov x0, #0 // return zero on success
> + ldp x19, x20, [sp, #16]
> + ldp x21, x22, [sp, #32]
> + ldp x23, x24, [sp, #48]
> + ldp x25, x26, [sp, #64]
> + ldp x27, x28, [sp, #80]
> + ldp x29, lr, [sp], #96
> + ret
> +ENDPROC(cpu_resume_after_mmu)
> +
> + .data
> +ENTRY(cpu_resume)
> + bl el2_setup // if in EL2 drop to EL1 cleanly
Compare to v2's patch set, here remove the calculation fro the offset
b/t PHYS_OFFSET - PAGE_OFFSET; so when i verify the patch set, i saw x28
is zero and finally introduce the EL2's sync exception. Below are pasted
v2's code for reference.
do u want use firmware to set the x28 for the offset value? :-) IMHO,
v2's implementation is more reasonable and it's better keep the code.
ENTRY(cpu_resume)
adr x4, sleep_save_sp
ldr x5, =sleep_save_sp
sub x28, x4, x5 // x28 = PHYS_OFFSET -
PAGE_OFFSET
/*
* make sure el2 is sane, el2_setup expects:
* x28 = PHYS_OFFSET - PAGE_OFFSET
*/
bl el2_setup // if in EL2 drop to EL1 cleanly
> +#ifdef CONFIG_SMP
> + mrs x1, mpidr_el1
> + adr x4, mpidr_hash_ptr
> + ldr x5, [x4]
> + add x8, x4, x5 // x8 = struct mpidr_hash phys address
> + /* retrieve mpidr_hash members to compute the hash */
> + ldr x2, [x8, #MPIDR_HASH_MASK]
> + ldp w3, w4, [x8, #MPIDR_HASH_SHIFTS]
> + ldp w5, w6, [x8, #(MPIDR_HASH_SHIFTS + 8)]
> + compute_mpidr_hash x7, x3, x4, x5, x6, x1, x2
> + /* x7 contains hash index, let's use it to grab context pointer */
> +#else
> + mov x7, xzr
> +#endif
> + adr x0, sleep_save_sp
> + ldr x0, [x0, #SLEEP_SAVE_SP_PHYS]
> + ldr x0, [x0, x7, lsl #3]
> + /* load sp from context */
> + ldr x2, [x0, #CPU_CTX_SP]
> + adr x1, sleep_idmap_phys
> + /* load physical address of identity map page table in x1 */
> + ldr x1, [x1]
> + mov sp, x2
> + /*
> + * cpu_do_resume expects x0 to contain context physical address
> + * pointer and x1 to contain physical address of 1:1 page tables
> + */
> + bl cpu_do_resume // PC relative jump, MMU off
> + b cpu_resume_mmu // Resume MMU, never returns
> +ENDPROC(cpu_resume)
> +
next prev parent reply other threads:[~2013-12-20 11:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 11:24 [PATCH RFC v3 00/12] arm64: suspend/resume implementation Lorenzo Pieralisi
2013-11-21 11:24 ` [PATCH RFC v3 01/12] arm64: kernel: add MPIDR_EL1 accessors macros Lorenzo Pieralisi
2013-11-21 11:24 ` [PATCH RFC v3 02/12] arm64: kernel: build MPIDR_EL1 hash function data structure Lorenzo Pieralisi
2013-11-21 11:24 ` [PATCH RFC v3 03/12] arm64: kernel: suspend/resume registers save/restore Lorenzo Pieralisi
2013-11-21 11:24 ` [PATCH RFC v3 04/12] arm64: kernel: cpu_{suspend/resume} implementation Lorenzo Pieralisi
2013-12-20 11:30 ` Leo Yan [this message]
2013-12-20 11:57 ` Catalin Marinas
2013-12-23 14:04 ` Lorenzo Pieralisi
2013-12-24 6:18 ` Leo Yan
2013-11-21 11:24 ` [PATCH RFC v3 05/12] arm64: kernel: implement fpsimd CPU PM notifier Lorenzo Pieralisi
2013-11-21 11:24 ` [PATCH RFC v3 06/12] arm: kvm: implement " Lorenzo Pieralisi
2013-11-27 3:02 ` Christoffer Dall
2013-11-21 11:24 ` [PATCH RFC v3 07/12] arm64: kernel: refactor code to install/uninstall breakpoints Lorenzo Pieralisi
2013-11-21 11:24 ` [PATCH RFC v3 08/12] arm64: kernel: implement HW breakpoints CPU PM notifier Lorenzo Pieralisi
2013-12-20 17:29 ` Will Deacon
2013-12-23 13:50 ` Lorenzo Pieralisi
2013-11-21 11:24 ` [PATCH RFC v3 09/12] arm64: enable generic clockevent broadcast Lorenzo Pieralisi
2013-11-21 11:24 ` [PATCH RFC v3 10/12] arm64: kernel: add CPU idle call Lorenzo Pieralisi
2013-11-21 11:24 ` [PATCH RFC v3 11/12] arm64: kernel: add PM build infrastructure Lorenzo Pieralisi
2013-11-21 11:24 ` [PATCH RFC v3 12/12] arm64: add CPU power management menu/entries Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B42A48.5090202@marvell.com \
--to=leoy@marvell$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox