From: s-anna@ti•com (Anna, Suman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 5/7] ARM: dts: Complete data for isp iommu
Date: Mon, 23 Dec 2013 18:10:27 -0600 [thread overview]
Message-ID: <52B8D0F3.5060508@ti.com> (raw)
In-Reply-To: <52B8AC55.70205@epfl.ch>
Hi Florian,
On 12/23/2013 03:34 PM, Florian Vaussard wrote:
> Hi Suman,
>
> On 12/23/2013 08:12 PM, Anna, Suman wrote:
>> Hi Florian,
>>
>> On 12/17/2013 06:53 AM, Florian Vaussard wrote:
>>> Add missing information required to probe the iommu for the camera
>>> subsystem.
>>>
>>> Signed-off-by: Florian Vaussard <florian.vaussard@epfl•ch>
>>> ---
>>> arch/arm/boot/dts/omap3.dtsi | 4 +++-
>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi
>>> index daabf99..610d084 100644
>>> --- a/arch/arm/boot/dts/omap3.dtsi
>>> +++ b/arch/arm/boot/dts/omap3.dtsi
>>> @@ -371,11 +371,13 @@
>>> dma-names = "tx", "rx";
>>> };
>>>
>>> - mmu_isp: mmu at 480bd400 {
>>> + mmu_isp: mmu_isp at 480bd400 {
>>
>> Any reason for switching the name to mmu_isp?
>>
>
> The name of the hwmod is "mmu_isp". This was not working otherwise,
> but I cannot tell you for sure why without getting back at my office.
Ok, did a bit of digging, this is due to the name tie-in for iommu arch
data (look at the omap3_camera_init in mach-omap2/devices.c), and the
obj->name assignment of of->name. This is another thing that needs to be
looked into since it would be preferable to move away from the name
based lookup towards using a phandle approach by the iommu consumer drivers.
regards
Suman
next prev parent reply other threads:[~2013-12-24 0:10 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 12:53 [PATCH 0/7] Fix omap-iommu probe and convert to DT for 3.14 Florian Vaussard
2013-12-17 12:53 ` [PATCH 1/7] iommu/omap: Do bus_set_iommu() only if probe() succeeds Florian Vaussard
2013-12-23 19:02 ` Anna, Suman
2013-12-23 21:07 ` Florian Vaussard
2013-12-23 23:35 ` Anna, Suman
2014-01-15 17:12 ` Florian Vaussard
2013-12-17 12:53 ` [PATCH 2/7] iommu/omap: omap_iommu_attach() should return ENODEV, not NULL Florian Vaussard
2013-12-23 18:45 ` Anna, Suman
2013-12-17 12:53 ` [PATCH 3/7] iommu/omap: Convert to devicetree Florian Vaussard
2013-12-23 19:48 ` Anna, Suman
2013-12-23 21:17 ` Florian Vaussard
2013-12-23 23:42 ` Anna, Suman
2014-01-02 0:13 ` Laurent Pinchart
2014-01-02 1:01 ` Sebastian Reichel
2014-01-15 17:16 ` Florian Vaussard
2013-12-17 12:53 ` [PATCH 4/7] iommu/omap: Allow enable/disable even without pdata Florian Vaussard
2013-12-23 19:05 ` Anna, Suman
2013-12-23 21:19 ` Florian Vaussard
2013-12-17 12:53 ` [PATCH 5/7] ARM: dts: Complete data for isp iommu Florian Vaussard
2013-12-23 19:12 ` Anna, Suman
2013-12-23 21:34 ` Florian Vaussard
2013-12-24 0:10 ` Anna, Suman [this message]
2013-12-17 12:53 ` [PATCH 6/7] ARM: OMAP2+: Remove legacy data from hwmod for omap3 " Florian Vaussard
2013-12-23 19:08 ` Anna, Suman
2013-12-23 21:36 ` Florian Vaussard
2013-12-23 23:28 ` Anna, Suman
2013-12-17 12:53 ` [PATCH 7/7] ARM: OMAP2+: Remove platform-specific omap-iommu Florian Vaussard
2013-12-23 18:52 ` [PATCH 0/7] Fix omap-iommu probe and convert to DT for 3.14 Anna, Suman
2013-12-23 20:51 ` Florian Vaussard
2013-12-23 23:54 ` Anna, Suman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B8D0F3.5060508@ti.com \
--to=s-anna@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox