From: ivan.khoronzhuk@ti•com (ivan.khoronzhuk)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 1/3] clocksource: timer-keystone: introduce clocksource driver for Keystone
Date: Tue, 24 Dec 2013 10:36:43 +0200 [thread overview]
Message-ID: <52B9479B.3040108@ti.com> (raw)
In-Reply-To: <20131224005804.GF31766@codeaurora.org>
On 12/24/2013 02:58 AM, Stephen Boyd wrote:
> On 12/17, Ivan Khoronzhuk wrote:
>> +static void __init keystone_timer_init(struct device_node *np)
>> +{
>> + struct clock_event_device *event_dev = &timer.event_dev;
>> + unsigned long rate;
> [...]
>> +
>> + timer.hz_period = rate / (HZ);
>
> Unnecessary parentheses here. Also, do you need to use do_div()
> here? I'm lost how the hz_period is ever greater than 32 bits
> though because HZ is most likely very small and the rate is
> unsigned long.
>
You are right.
I'll do the following:
timer.hz_period = rate / (HZ) ---> timer.hz_period = rate / HZ
u64 hz_period ---> unsigned long hz_period
--
Regards,
Ivan Khoronzhuk
next prev parent reply other threads:[~2013-12-24 8:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 16:22 [PATCH v2 0/3] Introduce clocksource driver for Keystone platform Ivan Khoronzhuk
2013-12-17 16:22 ` [PATCH v2 1/3] clocksource: timer-keystone: introduce clocksource driver for Keystone Ivan Khoronzhuk
2013-12-17 20:43 ` Santosh Shilimkar
2013-12-24 0:58 ` Stephen Boyd
2013-12-24 8:36 ` ivan.khoronzhuk [this message]
2013-12-24 11:36 ` ivan.khoronzhuk
2013-12-17 16:22 ` [PATCH v2 2/3] clocksource: keystone: add bindings for keystone timer Ivan Khoronzhuk
2013-12-17 20:43 ` Santosh Shilimkar
2013-12-17 16:22 ` [PATCH v2 3/3] arm: dts: keystone: add keystone timer entry Ivan Khoronzhuk
2013-12-17 20:44 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B9479B.3040108@ti.com \
--to=ivan.khoronzhuk@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox