From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: tegra: Remove 3.3V supply and modem regulators
Date: Mon, 06 Jan 2014 13:59:27 -0700 [thread overview]
Message-ID: <52CB192F.2020700@wwwdotorg.org> (raw)
In-Reply-To: <1389021933-6675-1-git-send-email-treding@nvidia.com>
On 01/06/2014 08:25 AM, Thierry Reding wrote:
> GPIO 1 and 2 of the PMIC are not used for the described purpose, so
> remove them.
As far as I can tell, this patch is correct, since those GPIOs are in
fact used to discharge the rails after disabling them, rather than to
enable/disable the rails.
Equally, these GPIOs affect multiple rails at once, so listing the GPIO
as a property of a single regulator seems wrong either way.
However, PMU_REGEN1 does seem to feed the "EN" pin of U13C1, a DC/DC
switcher for power rail 3.3v_modem, so perhaps there's more going on
here than I see?
In summary, I need Laxman to comment on this and ack the change, and
explain why these GPIOs were listed as regulator enables when it doesn't
seem that they are.
> Note: Removing these makes the work-in-progress eDP support work again.
> diff --git a/arch/arm/boot/dts/tegra124-venice2.dts b/arch/arm/boot/dts/tegra124-venice2.dts
> - vdd_3v3_reg: regulator at 1 {
> - compatible = "regulator-fixed";
> - reg = <1>;
> - regulator-name = "vdd_3v3";
> - regulator-min-microvolt = <3300000>;
> - regulator-max-microvolt = <3300000>;
> - regulator-always-on;
> - regulator-boot-on;
> - enable-active-high;
> - gpio = <&as3722 1 GPIO_ACTIVE_HIGH>;
> - };
> -
> - vdd_3v3_modem_reg: regulator at 2 {
> - compatible = "regulator-fixed";
> - reg = <2>;
> - regulator-name = "vdd-modem-3v3";
> - regulator-min-microvolt = <3300000>;
> - regulator-max-microvolt = <3300000>;
> - enable-active-high;
> - gpio = <&as3722 2 GPIO_ACTIVE_HIGH>;
> - };
Don't you want to simply remove the "enable-active-high" and "gpio"
properties, but leave the regulator definitions present, in case
something wants to reference these fixed(?) rails as their supply?
next prev parent reply other threads:[~2014-01-06 20:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-06 15:25 [PATCH] ARM: tegra: Remove 3.3V supply and modem regulators Thierry Reding
2014-01-06 20:59 ` Stephen Warren [this message]
2014-01-07 12:14 ` Laxman Dewangan
2014-01-07 16:43 ` Stephen Warren
2014-01-08 13:04 ` Laxman Dewangan
2014-01-08 13:41 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CB192F.2020700@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox