From: dave.long@linaro•org (David Long)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v4 04/16] ARM: move generic thumb instruction parsing code to new files for use by other feature
Date: Wed, 15 Jan 2014 11:41:19 -0500 [thread overview]
Message-ID: <52D6BA2F.4050104@linaro.org> (raw)
In-Reply-To: <1387543562.3404.35.camel@linaro1.home>
On 12/20/13 07:46, Jon Medhurst (Tixy) wrote:
> On Sun, 2013-12-15 at 23:08 -0500, David Long wrote:
>> From: "David A. Long" <dave.long@linaro•org>
>>
>> Move the thumb version of the kprobes instruction parsing code into more generic
>> files from where it can be used by uprobes and possibly other subsystems. The
>> symbol names will be made more generic in a subsequent part of this patchset.
>>
>> Signed-off-by: David A. Long <dave.long@linaro•org>
>> ---
>
> I just have two comments about probes-thumb.h ...
>
> [...]
>
>> diff --git a/arch/arm/kernel/probes-thumb.h b/arch/arm/kernel/probes-thumb.h
>> new file mode 100644
>> index 0000000..3f39210
>> --- /dev/null
>> +++ b/arch/arm/kernel/probes-thumb.h
>> @@ -0,0 +1,136 @@
>> +/*
>> + * arch/arm/kernel/probes-arm.h
>> + *
>> + * Copyright 2013 Linaro Ltd.
>> + * Written by: David A. Long
>> + *
>> + * The code contained herein is licensed under the GNU General Public
>> + * License. You may obtain a copy of the GNU General Public License
>> + * Version 2 or later at the following locations:
>> + *
>> + * http://www.opensource.org/licenses/gpl-license.html
>> + * http://www.gnu.org/copyleft/gpl.html
>> + */
>> +
>> +#ifndef _ARM_KERNEL_PROBES_THUMB_H
>> +#define _ARM_KERNEL_PROBES_THUMB_H
>> +
>> +/*
>> + * True if current instruction is in an IT block.
>> + */
>> +#define in_it_block(cpsr) ((cpsr & 0x06000c00) != 0x00000000)
>> +
>> +/*
>> + * Return the condition code to check for the currently executing instruction.
>> + * This is in ITSTATE<7:4> which is in CPSR<15:12> but is only valid if
>> + * in_it_block returns true.
>> + */
>> +#define current_cond(cpsr) ((cpsr >> 12) & 0xf)
>
> Looks like you forgot to remove above two #defines from kprobes-thumb.c
> when you moved them to this header file.
Fixed.
> Also...
>
>> +enum probes_t32_action {
>> + PROBES_T32_EMULATE_NONE,
>> + PROBES_T32_SIMULATE_NOP,
>> + PROBES_T32_LDMSTM,
>> + PROBES_T32_LDRDSTRD,
>> + PROBES_T32_TABLE_BRANCH,
>> + PROBES_T32_TST,
>> + PROBES_T32_CMP,
>> + PROBES_T32_MOV,
>> + PROBES_T32_ADDSUB,
>> + PROBES_T32_LOGICAL,
>> + PROBES_T32_ADDWSUBW_PC,
>> + PROBES_T32_ADDWSUBW,
>> + PROBES_T32_MOVW,
>> + PROBES_T32_SAT,
>> + PROBES_T32_BITFIELD,
>> + PROBES_T32_SEV,
>> + PROBES_T32_WFE,
>> + PROBES_T32_MRS,
>> + PROBES_T32_BRANCH_COND,
>> + PROBES_T32_BRANCH,
>> + PROBES_T32_PLDI,
>> + PROBES_T32_LDR_LIT,
>> + PROBES_T32_LDRSTR,
>> + PROBES_T32_SIGN_EXTEND,
>> + PROBES_T32_MEDIA,
>> + PROBES_T32_REVERSE,
>> + PROBES_T32_MUL_ADD,
>> + PROBES_T32_MUL_ADD2,
>> + PROBES_T32_MUL_ADD_LONG
>> +};
>> +
>> +enum probes_t16_action {
>> + PROBES_T16_ADD_SP,
>> + PROBES_T16_CBZ,
>> + PROBES_T16_SIGN_EXTEND,
>> + PROBES_T16_PUSH,
>> + PROBES_T16_POP,
>> + PROBES_T16_SEV,
>> + PROBES_T16_WFE,
>> + PROBES_T16_IT,
>> + PROBES_T16_CMP,
>> + PROBES_T16_ADDSUB,
>> + PROBES_T16_LOGICAL,
>> + PROBES_T16_BLX,
>> + PROBES_T16_HIREGOPS,
>> + PROBES_T16_LDR_LIT,
>> + PROBES_T16_LDRHSTRH,
>> + PROBES_T16_LDRSTR,
>> + PROBES_T16_ADR,
>> + PROBES_T16_LDMSTM,
>> + PROBES_T16_BRANCH_COND,
>> + PROBES_T16_BRANCH
>> +};
>> +
>
Moved.
-dl
next prev parent reply other threads:[~2014-01-15 16:41 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-16 4:08 [PATCH v4 00/16] uprobes: Add uprobes support for ARM David Long
2013-12-16 4:08 ` [PATCH v4 01/16] uprobes: allow ignoring of probe hits David Long
2013-12-16 4:08 ` [PATCH v4 02/16] ARM: move shared uprobe/kprobe definitions into new include file David Long
2013-12-20 12:46 ` Jon Medhurst (Tixy)
2014-01-15 16:43 ` David Long
2013-12-16 4:08 ` [PATCH v4 03/16] ARM: Move generic arm instruction parsing code to new files for sharing between features David Long
2013-12-16 4:08 ` [PATCH v4 04/16] ARM: move generic thumb instruction parsing code to new files for use by other feature David Long
2013-12-20 12:46 ` Jon Medhurst (Tixy)
2014-01-15 16:41 ` David Long [this message]
2013-12-16 4:08 ` [PATCH v4 05/16] ARM: use a function table for determining instruction interpreter actions David Long
2013-12-20 12:45 ` Jon Medhurst (Tixy)
2014-01-15 16:25 ` David Long
2013-12-16 4:08 ` [PATCH v4 06/16] ARM: Disable jprobes test when built into thumb-mode kernel David Long
2013-12-16 4:08 ` [PATCH v4 07/16] ARM: Remove use of struct kprobe from generic probes code David Long
2013-12-20 13:55 ` Jon Medhurst (Tixy)
2014-01-15 16:44 ` David Long
2013-12-16 4:08 ` [PATCH v4 08/16] ARM: Use new opcode type in ARM kprobes/uprobes code David Long
2013-12-16 4:08 ` [PATCH v4 09/16] ARM: Make the kprobes condition_check symbol names more generic David Long
2013-12-16 4:08 ` [PATCH v4 10/16] ARM: Change more ARM kprobes symbol names to something more David Long
2013-12-16 4:08 ` [PATCH v4 11/16] ARM: Rename the shared kprobes/uprobe return value enum David Long
2013-12-16 4:08 ` [PATCH v4 12/16] ARM: Change the remaining shared kprobes/uprobes symbols to something generic David Long
2013-12-16 4:08 ` [PATCH v4 13/16] ARM: Add an emulate flag to the kprobes/uprobes instruction decode functions David Long
2013-12-20 14:58 ` Jon Medhurst (Tixy)
2014-01-15 19:31 ` David Long
2014-01-16 9:18 ` Jon Medhurst (Tixy)
2014-01-16 18:12 ` David Long
2013-12-16 4:08 ` [PATCH v4 14/16] ARM: Make arch_specific_insn a define for new arch_probes_insn structure David Long
2013-12-16 4:08 ` [PATCH v4 15/16] ARM: add uprobes support David Long
2013-12-20 18:34 ` Jon Medhurst (Tixy)
2013-12-20 19:00 ` Rabin Vincent
2013-12-20 19:47 ` Jon Medhurst (Tixy)
2013-12-23 15:32 ` Oleg Nesterov
2014-01-21 16:51 ` David Long
2013-12-16 4:08 ` [PATCH v4 16/16] ARM: Remove uprobes dependency on kprobes David Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D6BA2F.4050104@linaro.org \
--to=dave.long@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox