From: emilio@elopez•com.ar (Emilio López)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 2/8] clk: sunxi: update clock-output-names dt binding documentation
Date: Thu, 16 Jan 2014 23:55:45 -0300 [thread overview]
Message-ID: <52D89BB1.3030206@elopez.com.ar> (raw)
In-Reply-To: <1389257565-19797-3-git-send-email-wens@csie.org>
Hi,
El 09/01/14 05:52, Chen-Yu Tsai escribi?:
> clock-output-names is now required for most of sunxi clock nodes, to
> provide the name of the corresponding clock. Add the new requirements,
> exceptions, as well as examples.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie•org>
> ---
> Documentation/devicetree/bindings/clock/sunxi.txt | 36 +++++++++++++++++++----
> 1 file changed, 31 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/sunxi.txt b/Documentation/devicetree/bindings/clock/sunxi.txt
> index 0c127cd..8a9147d 100644
> --- a/Documentation/devicetree/bindings/clock/sunxi.txt
> +++ b/Documentation/devicetree/bindings/clock/sunxi.txt
> @@ -44,10 +44,18 @@ Required properties for all clocks:
> multiplexed clocks, the list order must match the hardware
> programming order.
> - #clock-cells : from common clock binding; shall be set to 0 except for
> - "allwinner,*-gates-clk" where it shall be set to 1
> + "allwinner,*-gates-clk", "allwinner,sun4i-pll5-clk" and
> + "allwinner,sun4i-pll6-clk" where it shall be set to 1
>
> -Additionally, "allwinner,*-gates-clk" clocks require:
> -- clock-output-names : the corresponding gate names that the clock controls
> +Additionally, most clocks require "clock-output-names":
> +- "allwinner,*-gates-clk" : the corresponding gate names that the clock controls
> +- "allwinner,sun4i-pll5-clk" : "pll5_ddr", "pll5_mbus"
> +- "allwinner,sun4i-pll6-clk" : "pll6_sata", "pll6_other"
> +- "allwinner,sun4i-cpu-clk", "allwinner,sun4i-axi-clk",
> + "allwinner,sun4i-ahb-clk", "allwinner,sun4i-ahb-clk",
> + "allwinner,sun4i-apb1-mux-clk", "allwinner,sun4i-apb1-clk"
> + do not need "clock-output-names"
> +- all others clocks : the corresponding module name of that clock
As we discussed on IRC, I wonder if such verbosity is actually needed.
Maybe we should dictate that all clocks must list their corresponding
outputs on clock-output-names (with it being the module name if it only
has one output).
Cheers,
Emilio
next prev parent reply other threads:[~2014-01-17 2:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-09 8:52 [PATCH v3 0/8] ARM: sunxi: rename DT clock node names to clk@N Chen-Yu Tsai
2014-01-09 8:52 ` [PATCH v3 1/8] clk: sunxi: add clock-output-names dt property support Chen-Yu Tsai
2014-01-15 7:46 ` Maxime Ripard
2014-01-09 8:52 ` [PATCH v3 2/8] clk: sunxi: update clock-output-names dt binding documentation Chen-Yu Tsai
2014-01-15 8:00 ` Maxime Ripard
2014-01-17 2:55 ` Emilio López [this message]
2014-01-29 1:52 ` Chen-Yu Tsai
2014-01-30 15:43 ` Maxime Ripard
2014-01-09 8:52 ` [PATCH v3 3/8] clk: sunxi: add names for pll5, pll6 parent clocks to factors_data Chen-Yu Tsai
2014-01-15 7:44 ` Maxime Ripard
2014-01-09 8:52 ` [PATCH v3 4/8] clk: sunxi: get divs parent clock name from parent factor clock Chen-Yu Tsai
2014-01-09 8:52 ` [PATCH v3 5/8] ARM: dts: sun4i: rename clock node names to clk@N Chen-Yu Tsai
2014-01-09 8:52 ` [PATCH v3 6/8] ARM: dts: sun5i: " Chen-Yu Tsai
2014-01-09 8:52 ` [PATCH v3 7/8] ARM: dts: sun6i: " Chen-Yu Tsai
2014-01-09 8:52 ` [PATCH v3 8/8] ARM: dts: sun7i: " Chen-Yu Tsai
2014-01-17 3:06 ` [PATCH v3 0/8] ARM: sunxi: rename DT " Emilio López
2014-01-18 0:23 ` Mike Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D89BB1.3030206@elopez.com.ar \
--to=emilio@elopez$(echo .)com.ar \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox