From: t.figa@samsung•com (Tomasz Figa)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/2] clk: exynos4: Fix spacing related checkpatch errors
Date: Mon, 20 Jan 2014 13:07:30 +0100 [thread overview]
Message-ID: <52DD1182.80200@samsung.com> (raw)
In-Reply-To: <1389780070-4959-2-git-send-email-sachin.kamat@linaro.org>
Hi Sachin,
On 15.01.2014 11:01, Sachin Kamat wrote:
> Silences the following type of checkpatch errors:
> ERROR: space prohibited after that open parenthesis '('
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro•org>
> ---
> drivers/clk/samsung/clk-exynos4.c | 50 ++++++++++++++++++-------------------
> 1 file changed, 25 insertions(+), 25 deletions(-)
I believe this is a false warning. In this special case the spaces
greatly improve readability of static data in the driver, which I
believe is preferred over the strict rules of checkpatch.
Best regards,
Tomasz
next prev parent reply other threads:[~2014-01-20 12:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-15 10:01 [PATCH 1/2] clk: samsung: pll: Fix checkpatch errors Sachin Kamat
2014-01-15 10:01 ` [PATCH 2/2] clk: exynos4: Fix spacing related " Sachin Kamat
2014-01-20 12:07 ` Tomasz Figa [this message]
2014-01-24 9:07 ` Sachin Kamat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52DD1182.80200@samsung.com \
--to=t.figa@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox