From: gregory.clement@free-electrons•com (Gregory CLEMENT)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/2] at91: gpio: use gpiolib API to mark a GPIO used as an IRQ
Date: Wed, 22 Jan 2014 13:47:07 +0100 [thread overview]
Message-ID: <52DFBDCB.4020501@free-electrons.com> (raw)
In-Reply-To: <1390394341-12548-1-git-send-email-jjhiblot@traphandler.com>
Hi Jean-Jacques,
On 22/01/2014 13:39, Jean-Jacques Hiblot wrote:
> When an IRQ is started on a GPIO line, mark this GPIO as IRQ in
> the gpiolib so we can keep track of the usage centrally.
>
> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@traphandler•com>
> ---
> arch/arm/mach-at91/gpio.c | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/arch/arm/mach-at91/gpio.c b/arch/arm/mach-at91/gpio.c
> index a5afcf7..6176b4b 100644
> --- a/arch/arm/mach-at91/gpio.c
> +++ b/arch/arm/mach-at91/gpio.c
> @@ -577,8 +577,32 @@ static int alt_gpio_irq_type(struct irq_data *d, unsigned type)
> return 0;
> }
>
> +static unsigned int gpio_irq_startup(struct irq_data *d)
> +{
> + struct at91_gpio_chip *at91_gpio = irq_data_get_irq_chip_data(d);
> + unsigned pin = d->hwirq;
> + int ret;
> +
> + ret = gpio_lock_as_irq(&at91_gpio->chip, pin);
> + if (ret) {
> + dev_err(at91_gpio->chip.dev, "unable to lock pind %lu IRQ\n",
> + d->hwirq);
> + return ret;
> + }
> + return 0;
> +}
Nitpick: a blank line should be nice here between the 2 functions
> +static void gpio_irq_shutdown(struct irq_data *d)
> +{
> + struct at91_gpio_chip *at91_gpio = irq_data_get_irq_chip_data(d);
> + unsigned pin = d->hwirq;
> +
> + gpio_unlock_as_irq(&at91_gpio->chip, pin);
> +}
> +
> static struct irq_chip gpio_irqchip = {
> .name = "GPIO",
> + .irq_shutdown = gpio_irq_shutdown,
> + .irq_startup = gpio_irq_startup,
> .irq_disable = gpio_irq_mask,
> .irq_mask = gpio_irq_mask,
> .irq_unmask = gpio_irq_unmask,
>
Thanks,
Gregory
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
prev parent reply other threads:[~2014-01-22 12:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-22 12:39 [PATCH 1/2] at91: gpio: use gpiolib API to mark a GPIO used as an IRQ Jean-Jacques Hiblot
2014-01-22 12:39 ` [PATCH 2/2] at91: pinctrl: " Jean-Jacques Hiblot
2014-01-22 12:49 ` Gregory CLEMENT
2014-01-22 12:47 ` Gregory CLEMENT [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52DFBDCB.4020501@free-electrons.com \
--to=gregory.clement@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox