From: sergei.shtylyov@cogentembedded•com (Sergei Shtylyov)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v8 3/4] ohci-platform: Add support for controllers with big-endian regs / descriptors
Date: Wed, 22 Jan 2014 23:46:11 +0300 [thread overview]
Message-ID: <52E02E13.9070206@cogentembedded.com> (raw)
In-Reply-To: <1390419177-6481-4-git-send-email-hdegoede@redhat.com>
Hello.
On 01/22/2014 10:32 PM, Hans de Goede wrote:
> Note this commit uses the same devicetree booleans for this as the ones
> already existing in the usb-ehci bindings, see:
> Documentation/devicetree/bindings/usb/usb-ehci.txt
> Signed-off-by: Hans de Goede <hdegoede@redhat•com>
[...]
> diff --git a/drivers/usb/host/ohci-platform.c b/drivers/usb/host/ohci-platform.c
> index b2d0e1e..71e9d8e 100644
> --- a/drivers/usb/host/ohci-platform.c
> +++ b/drivers/usb/host/ohci-platform.c
[...]
> @@ -164,8 +165,34 @@ static int ohci_platform_probe(struct platform_device *dev)
[...]
> +#ifndef CONFIG_USB_OHCI_BIG_ENDIAN_MMIO
> + if (ohci->flags & OHCI_QUIRK_BE_MMIO) {
> + dev_err(&dev->dev,
> + "Error big-endian-regs not compiled in\n");
> + err = -EINVAL;
> + goto err_put_hcd;
> + }
> +#endif
> +#ifndef CONFIG_USB_OHCI_BIG_ENDIAN_DESC
> + if (ohci->flags & OHCI_QUIRK_BE_DESC) {
> + dev_err(&dev->dev,
> + "Error big-endian-desc not compiled in\n");
Small grammar nits (sorry): some punctuation like comma or semicolon
wouldn't hurt after "Error" word here and above. The same for ehci-platfrom.c.
Also, "support" word wouldn't hurt after the property names in the same message.
WBR, Sergei
next prev parent reply other threads:[~2014-01-22 20:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-22 19:32 [PATCH v8 0/4] ohci and ehci-platform clks, phy, be and dt support Hans de Goede
2014-01-22 19:32 ` [PATCH v8 1/4] ohci-platform: Add support for devicetree instantiation Hans de Goede
2014-01-22 19:32 ` [PATCH v8 2/4] ehci-platform: Add support for clks and phy passed through devicetree Hans de Goede
2014-01-22 19:32 ` [PATCH v8 3/4] ohci-platform: Add support for controllers with big-endian regs / descriptors Hans de Goede
2014-01-22 20:46 ` Sergei Shtylyov [this message]
2014-01-22 19:32 ` [PATCH v8 4/4] ehci-platform: " Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E02E13.9070206@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox