From: florian.vaussard@epfl•ch (Florian Vaussard)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 3/3] ARM: dts: Add support for both OMAP35xx and OMAP36xx Overo/Tobi
Date: Thu, 06 Feb 2014 16:13:05 +0100 [thread overview]
Message-ID: <52F3A681.9050300@epfl.ch> (raw)
In-Reply-To: <52F39DCC.8000006@ti.com>
On 02/06/2014 03:35 PM, Nishanth Menon wrote:
> On 02/06/2014 03:10 AM, Florian Vaussard wrote:
>> Unfortunatly the device tree for older OMAP35xx Overo cannot be used
> Unfortunately ?
Indeed
>> with newer OMAP36xx and vice-versa. To address this issue, move most of
>> the Tobi DTS to a common include file, and create model-specific Tobi
>> DTS.
>>
> [...]
>> diff --git a/arch/arm/boot/dts/omap3-overo-tobi.dts b/arch/arm/boot/dts/omap3-overo-tobi.dts
>> new file mode 100644
>> index 0000000..2f82192
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/omap3-overo-tobi.dts
>> @@ -0,0 +1,22 @@
>> +/*
>> + * Copyright (C) 2012 Florian Vaussard, EPFL Mobots group
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 as
>> + * published by the Free Software Foundation.
>> + */
>> +
>> +/*
>> + * Tobi expansion board is manufactured by Gumstix Inc.
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include "omap34xx.dtsi"
>> +#include "omap3-overo-tobi-common.dtsi"
>> +
>> +/ {
>> + model = "OMAP35xx Gumstix Overo on Tobi";
>> + compatible = "gumstix,omap3-overo-tobi", "gumstix,omap3-overo", "ti,omap3";
> To reduce any future problems, I suggest:
> compatible = "gumstix,omap3-overo-tobi", "gumstix,omap3-overo",
> "ti,omap3430", "ti,omap3";
>
This was also my first thought, but "ti,omap3430" is not documented in
Documentation/devicetree/bindings/arm/omap/omap.txt. It is said that
"ti,omap3" defaults to OMAP3430. I do not know if omap35xx would be more
accurate, as these Overo are using OMAP3503 and OMAP3530.
Regards,
Florian
next prev parent reply other threads:[~2014-02-06 15:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-06 9:10 [PATCH 0/3] ARM: dts: Fixes for Overo/Tobi against 3.14-rc1 Florian Vaussard
2014-02-06 9:10 ` [PATCH 1/3] ARM: dts: omap3-tobi: Fix boot with OMAP36xx-based Overo Florian Vaussard
2014-02-06 9:10 ` [PATCH 2/3] ARM: dts: omap3-tobi: Use the correct vendor prefix Florian Vaussard
2014-02-06 9:10 ` [PATCH 3/3] ARM: dts: Add support for both OMAP35xx and OMAP36xx Overo/Tobi Florian Vaussard
2014-02-06 14:35 ` Nishanth Menon
2014-02-06 15:13 ` Florian Vaussard [this message]
2014-02-06 15:18 ` Nishanth Menon
2014-02-06 17:09 ` [PATCH 0/3] ARM: dts: Fixes for Overo/Tobi against 3.14-rc1 Kevin Hilman
2014-02-11 13:07 ` Florian Vaussard
2014-02-11 16:47 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F3A681.9050300@epfl.ch \
--to=florian.vaussard@epfl$(echo .)ch \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox