From: nicolas.ferre@atmel•com (Nicolas Ferre)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 06/15] at91: dt: at91sam9261ek: Adds DT entries for the 4 user buttons
Date: Fri, 7 Feb 2014 11:22:31 +0100 [thread overview]
Message-ID: <52F4B3E7.2080000@atmel.com> (raw)
In-Reply-To: <CACh+v5O_CMcYKBKLzbcD2ypGLX_Pp+64fiqO4MWYw-J4h0KA7A@mail.gmail.com>
On 07/02/2014 10:30, Jean-Jacques Hiblot :
> 2014-02-07 Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft•com>:
>> On 16:57 Thu 23 Jan , Jean-Jacques Hiblot wrote:
>>> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@traphandler•com>
>>> ---
>>> arch/arm/boot/dts/at91sam9261ek.dts | 39 +++++++++++++++++++++++++++++++++++++
>>> 1 file changed, 39 insertions(+)
>>
>> do only one patch for the 9261ek support no nned to clean
>>>
>>> diff --git a/arch/arm/boot/dts/at91sam9261ek.dts b/arch/arm/boot/dts/at91sam9261ek.dts
>>> index 8909217..5555e9f5 100644
>>> --- a/arch/arm/boot/dts/at91sam9261ek.dts
>>> +++ b/arch/arm/boot/dts/at91sam9261ek.dts
>>> @@ -83,6 +83,15 @@
>>> AT91_PIOA 23 AT91_PERIPH_GPIO AT91_PINCTRL_NONE>;
>>> };
>>> };
>>> +
>>> + keys {
>>> + pinctrl_keys: keys-0 {
>>> + atmel,pins = <AT91_PIOA 27 AT91_PERIPH_GPIO AT91_PINCTRL_NONE
>>> + AT91_PIOA 26 AT91_PERIPH_GPIO AT91_PINCTRL_NONE
>>> + AT91_PIOA 25 AT91_PERIPH_GPIO AT91_PINCTRL_NONE
>>> + AT91_PIOA 24 AT91_PERIPH_GPIO AT91_PINCTRL_NONE>;
>>> + };
>>> + };
>>
>> no need this you can drop it
> ok. I thought that it would help the user to understand the GPIO usage.
> I'll remove all pinmux for GPIO that don't require a special hardware
> configuration
Well, me also, I like to see what the board requires for functioning
properly. It is convenient for:
- understanding clearly what is used and what is not
- doing a grep when searching where a particular GPIO is used
- describing completely the hardware (which is the purpose of DT)
So, I would like additional consideration by more AT91 users before
following this rule... And maybe a note by Linus W.
Bye,
>>
>> you just describe a gpio which we do not describe in pinctrl
>>> };
>>>
>>> watchdog at fffffd40 {
>>> @@ -109,4 +118,34 @@
>>> linux,default-trigger = "heartbeat";
>>> };
>>> };
>>> +
>>> + gpio_keys {
>>> + compatible = "gpio-keys";
>>> + pinctrl-0 = <&pinctrl_keys>;
>>> +
>>> + button_0 {
>>> + label = "button_0";
>>> + gpios = <&pioA 27 GPIO_ACTIVE_LOW>;
>>> + linux,code = <256>;
>>> + gpio-key,wakeup;
>>> + };
>>> + button_1 {
>>> + label = "button_1";
>>> + gpios = <&pioA 26 GPIO_ACTIVE_LOW>;
>>> + linux,code = <257>;
>>> + gpio-key,wakeup;
>>> + };
>>> + button_2 {
>>> + label = "button_2";
>>> + gpios = <&pioA 25 GPIO_ACTIVE_LOW>;
>>> + linux,code = <258>;
>>> + gpio-key,wakeup;
>>> + };
>>> + button_3 {
>>> + label = "button_3";
>>> + gpios = <&pioA 24 GPIO_ACTIVE_LOW>;
>>> + linux,code = <259>;
>>> + gpio-key,wakeup;
>>> + };
>>> + };
>>> };
>>> --
>>> 1.8.5.2
>>>
>
>
--
Nicolas Ferre
next prev parent reply other threads:[~2014-02-07 10:22 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 15:57 [PATCH v3 00/15] Device Tree support for the at91sam9261ek Jean-Jacques Hiblot
2014-01-23 15:57 ` [PATCH v3 01/15] at91: dt: Add at91sam9261 dt SoC support Jean-Jacques Hiblot
2014-02-07 8:23 ` Jean-Christophe PLAGNIOL-VILLARD
2014-02-07 8:43 ` Boris BREZILLON
2014-02-07 9:47 ` Jean-Jacques Hiblot
2014-01-23 15:57 ` [PATCH v3 02/15] at91: dt: defconfig: Added the sam9261 to the list of supported SOCs Jean-Jacques Hiblot
2014-01-23 15:57 ` [PATCH v3 03/15] at91: dt: sam9261: Basic Device Tree support for the at91sam9261ek Jean-Jacques Hiblot
2014-02-07 8:30 ` Jean-Christophe PLAGNIOL-VILLARD
2014-02-07 9:33 ` Jean-Jacques Hiblot
2014-01-23 15:57 ` [PATCH v3 04/15] ARM: at91: prepare common clk transition for sam9261 SoC Jean-Jacques Hiblot
2014-02-07 8:25 ` Jean-Christophe PLAGNIOL-VILLARD
2014-02-07 8:35 ` Boris BREZILLON
2014-02-07 9:38 ` Jean-Jacques Hiblot
2014-01-23 15:57 ` [PATCH v3 05/15] ARM: at91: move sam9261 SoC to common clk Jean-Jacques Hiblot
2014-02-07 8:58 ` Boris BREZILLON
2014-01-23 15:57 ` [PATCH v3 06/15] at91: dt: at91sam9261ek: Adds DT entries for the 4 user buttons Jean-Jacques Hiblot
2014-02-07 8:27 ` Jean-Christophe PLAGNIOL-VILLARD
2014-02-07 9:30 ` Jean-Jacques Hiblot
2014-02-07 10:22 ` Nicolas Ferre [this message]
2014-02-10 9:51 ` Linus Walleij
2014-01-23 15:57 ` [PATCH v3 07/15] at91: dt: sam9261: Added the descriptions of hck0 and hck1 clocks (CCF) Jean-Jacques Hiblot
2014-01-23 15:57 ` [PATCH v3 08/15] at91: dt: sam9261: Added hclk declaration for the fb driver (non-CCF) Jean-Jacques Hiblot
2014-01-23 15:57 ` [PATCH v3 09/15] at91: dt: sam9261: Added support for the LCD display Jean-Jacques Hiblot
2014-01-23 15:57 ` [PATCH v3 10/15] at91: dt: at91sam9261ek: " Jean-Jacques Hiblot
2014-01-23 15:57 ` [PATCH v3 11/15] at91: dt: Adds support for the bus matrix declaration in the device tree Jean-Jacques Hiblot
2014-01-23 15:57 ` [PATCH v3 12/15] at91: dt: sam9261: adds description for the bus matrix Jean-Jacques Hiblot
2014-01-23 15:57 ` [PATCH v3 13/15] at91: dt: sam9261: CCF: Added USB clocks Jean-Jacques Hiblot
2014-01-23 15:57 ` [PATCH v3 14/15] at91: dt: at91sam9261ek: Enabled the USB host port (OHCI) Jean-Jacques Hiblot
2014-01-23 15:57 ` [PATCH v3 15/15] at91: dt: at91sam9261ek: Enabled the USB device port Jean-Jacques Hiblot
2014-02-07 8:33 ` [PATCH v3 00/15] Device Tree support for the at91sam9261ek Jean-Christophe PLAGNIOL-VILLARD
2014-02-07 9:36 ` Jean-Jacques Hiblot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F4B3E7.2080000@atmel.com \
--to=nicolas.ferre@atmel$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox