From: gregory.clement@free-electrons•com (Gregory CLEMENT)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/3] ARM: mvebu: remove unneeded ->map_io field for Armada 370/XP
Date: Tue, 11 Feb 2014 18:43:48 +0100 [thread overview]
Message-ID: <52FA6154.20809@free-electrons.com> (raw)
In-Reply-To: <1392138433-12573-2-git-send-email-thomas.petazzoni@free-electrons.com>
On 11/02/2014 18:07, Thomas Petazzoni wrote:
> The ->map_io() implementation of Armada 370/XP simply calls
> debug_ll_io_init(), which is exactly what the kernel does when
> ->map_io is NULL. Therefore, there is no need to have a specific
> ->map_io() implementation in Armada 370/XP.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons•com>
We missed it because the change made in arch/arm/mm/mmu.c was made in the same time
than our change in arch/arm/mach-mvebu/armada-370-xp.c to use debug_ll_io_init().
Acked-by: Gregory CLEMENT <gregory.clement@free-electrons•com>
> ---
> arch/arm/mach-mvebu/armada-370-xp.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/arch/arm/mach-mvebu/armada-370-xp.c b/arch/arm/mach-mvebu/armada-370-xp.c
> index f6c9d1d..161cf2f 100644
> --- a/arch/arm/mach-mvebu/armada-370-xp.c
> +++ b/arch/arm/mach-mvebu/armada-370-xp.c
> @@ -31,11 +31,6 @@
> #include "coherency.h"
> #include "mvebu-soc-id.h"
>
> -static void __init armada_370_xp_map_io(void)
> -{
> - debug_ll_io_init();
> -}
> -
> static void __init armada_370_xp_timer_and_clk_init(void)
> {
> of_clk_init(NULL);
> @@ -90,7 +85,6 @@ static const char * const armada_370_xp_dt_compat[] = {
> DT_MACHINE_START(ARMADA_XP_DT, "Marvell Armada 370/XP (Device Tree)")
> .smp = smp_ops(armada_xp_smp_ops),
> .init_machine = armada_370_xp_dt_init,
> - .map_io = armada_370_xp_map_io,
> .init_time = armada_370_xp_timer_and_clk_init,
> .restart = mvebu_restart,
> .dt_compat = armada_370_xp_dt_compat,
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2014-02-11 17:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 17:07 [PATCH 0/3] Minor Armada 370/XP cleanups Thomas Petazzoni
2014-02-11 17:07 ` [PATCH 1/3] ARM: mvebu: remove unneeded ->map_io field for Armada 370/XP Thomas Petazzoni
2014-02-11 17:43 ` Gregory CLEMENT [this message]
2014-02-11 19:34 ` Jason Cooper
2014-02-11 17:07 ` [PATCH 2/3] ARM: mvebu: use GPIO DT defines in Armada 370/XP boards Thomas Petazzoni
2014-02-11 17:44 ` Gregory CLEMENT
2014-02-11 19:41 ` Jason Cooper
2014-02-12 7:49 ` Andrew Lunn
2014-02-12 9:24 ` Thomas Petazzoni
2014-02-12 15:52 ` Jason Cooper
2014-02-11 17:07 ` [PATCH 3/3] ARM: mvebu: use input " Thomas Petazzoni
2014-02-11 17:47 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FA6154.20809@free-electrons.com \
--to=gregory.clement@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox