From: nm@ti•com (Nishanth Menon)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] mmc: omap_hsmmc: Add support for Erratum 2.1.1.128 in device tree boot
Date: Thu, 13 Feb 2014 23:48:54 -0600 [thread overview]
Message-ID: <52FDAE46.4060501@ti.com> (raw)
In-Reply-To: <20140213230554.GI28216@atomide.com>
On 02/13/2014 05:05 PM, Tony Lindgren wrote:
> * Nishanth Menon <nm@ti•com> [140205 06:15]:
>> On Wed 05 Feb 2014 08:10:34 AM CST, Balaji T K wrote:
>>>>>
>>>>> Rather than ti,errata.. specific property, something like
>>>>> caps no/disable multiblock read is more readable in my opinion, Otherwise
>>>>
>>>> Is'nt the better definition to state i have quirk X and allow the
>>>> driver to do the necessary thing/things needed to handle quirk X? in
>>>> this case, there is just one thing to do: broken multi_block_read, in
>>>> the case of other quirks, there might be more than 1 thing to do.. let
>>>> driver figure that out, dts just states the h/w capabilty or in this
>>>> case, the quirk capability.
>>>>
>>>
>>> But in this case there is only one. disable multi block read is more readable
>>> than the errata reference, No strong feelings though.
>>
>> Considering this might set an precedence for other quirk description,
>> I'd like to leave it as it stands.
>
> Hmm if this really depends on the hardware version, how about
> just add new compatible flag ti,omap3430-rev-xyz-hsmmc that
> allows the driver to deal with the errata?
>
yep - that is a very good idea. updated v2 series tested and posted:
http://marc.info/?l=linux-omap&m=139235682727541&w=2
https://patchwork.kernel.org/patch/3650061/
https://patchwork.kernel.org/patch/3650031/
--
Regards,
Nishanth Menon
prev parent reply other threads:[~2014-02-14 5:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-20 23:29 [PATCH] mmc: omap_hsmmc: Add support for Erratum 2.1.1.128 in device tree boot Nishanth Menon
2014-01-20 23:39 ` Felipe Balbi
2014-01-21 17:38 ` Nishanth Menon
2014-01-21 18:05 ` Felipe Balbi
2014-01-21 19:39 ` Nishanth Menon
2014-01-21 19:45 ` Felipe Balbi
2014-02-04 12:44 ` Balaji T K
2014-02-04 15:18 ` Nishanth Menon
2014-02-05 14:10 ` Balaji T K
2014-02-05 14:12 ` Nishanth Menon
2014-02-13 23:05 ` Tony Lindgren
2014-02-14 5:48 ` Nishanth Menon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FDAE46.4060501@ti.com \
--to=nm@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox