From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/2] clk: fixed-rate: use full DT node name
Date: Fri, 14 Feb 2014 09:43:51 -0700 [thread overview]
Message-ID: <52FE47C7.3050509@wwwdotorg.org> (raw)
In-Reply-To: <20140214103556.GC9907@e106331-lin.cambridge.arm.com>
On 02/14/2014 03:35 AM, Mark Rutland wrote:
> On Fri, Feb 14, 2014 at 06:16:52AM +0000, Stephen Warren wrote:
>> clk-fixed-rate currently names clocks according to a node's name without
>> the unit address. When faced with the legal and technically correct DT
>> structure below, this causes rgistration attempts for 3 clocks with the
>> same name, 2 of which fail.
>>
>> clocks {
>> compatible = "simple-bus";
>> #address-cells = <1>;
>> #size-cells = <0>;
>>
>> clk_mmc: clock at 0 {
>> compatible = "fixed-clock";
>> reg = <0>;
>> ...
>> clk_i2c: clock at 1 {
>> compatible = "fixed-clock";
>> reg = <1>;
>> ...
>> clk_spi: clock at 2 {
>> compatible = "fixed-clock";
>> reg = <2>;
>> ...
>
> I'd argue that this case isn't valid.
>
> The fixed-clock binding doesn't define a reg, yet simple bus binding
> implies that the reg property of child nodes should be interpretted as
> the same address space as their parent (MMIO in this case?). The
> fixed-clock nodes reg proeprties clearly aren't MMIO addresses.
>
> Additionally, the _requred_ ranges property is missing.
Oh, IIRC that was deliberate to indicate that the child address space
was disjoint from the parent address space.
next prev parent reply other threads:[~2014-02-14 16:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-14 6:16 [PATCH 1/2] clk: fixed-rate: use full DT node name Stephen Warren
2014-02-14 6:16 ` [PATCH 2/2] ARM: bcm2835: fix clock DT node names Stephen Warren
2014-02-14 10:39 ` Mark Rutland
2014-02-14 10:35 ` [PATCH 1/2] clk: fixed-rate: use full DT node name Mark Rutland
2014-02-14 16:43 ` Stephen Warren
2014-02-18 11:23 ` Mark Rutland
2014-02-18 17:34 ` Stephen Warren
2014-02-14 16:43 ` Stephen Warren [this message]
2014-02-15 15:18 ` Emilio López
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FE47C7.3050509@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox