From: kgene.kim@samsung•com (Kukjin Kim)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 19/73] arm: mach-s3c64xx mach-crag6410-module.c is not modular
Date: Sun, 16 Feb 2014 02:04:00 +0900 [thread overview]
Message-ID: <52FF9E00.90005@samsung.com> (raw)
In-Reply-To: <20140123131621.GD11589@opensource.wolfsonmicro.com>
On 01/23/14 22:16, Charles Keepax wrote:
> On Tue, Jan 21, 2014 at 04:22:22PM -0500, Paul Gortmaker wrote:
>> Despite the name mach-crag6410-module.c, the code is built for
>> MACH_WLF_CRAGG_6410 -- which is bool, and hence this code is
>> either present or absent. It will never be modular, so using
>> module_init as an alias for __initcall can be somewhat
>> misleading.
>>
>> Fix this up now, so that we can relocate module_init from
>> init.h into module.h in the future. If we don't do this, we'd
>> have to add module.h to obviously non-modular code, and that
>> would be a worse thing.
>>
>> Note that direct use of __initcall is discouraged, vs. one
>> of the priority categorized subgroups. As __initcall gets
>> mapped onto device_initcall, our use of device_initcall
>> directly in this change means that the runtime impact is
>> zero -- it will remain at level 6 in initcall ordering.
>>
>> Cc: Ben Dooks<ben-linux@fluff•org>
>> Cc: Kukjin Kim<kgene.kim@samsung•com>
>> Cc: Russell King<linux@arm•linux.org.uk>
>> Cc: patches at opensource.wolfsonmicro.com
>> Cc: linux-arm-kernel at lists.infradead.org
>> Signed-off-by: Paul Gortmaker<paul.gortmaker@windriver•com>
>> ---
>
> Tested-by: Charles Keepax<ckeepax@opensource•wolfsonmicro.com>
>
Thanks, applied.
- Kukjin
next prev parent reply other threads:[~2014-02-15 17:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-21 21:22 [PATCH RFC 00/73] tree-wide: clean up some no longer required #include <linux/init.h> Paul Gortmaker
2014-01-21 21:22 ` [PATCH 16/73] arm: include module.h in drivers/bus/omap_l3_smx.c Paul Gortmaker
2014-01-21 21:22 ` [PATCH 17/73] arm: fix implicit module.h use in mach-at91 gpio.h Paul Gortmaker
2014-01-21 21:22 ` [PATCH 18/73] arm: fix implicit #include <linux/init.h> in entry asm Paul Gortmaker
2014-01-21 21:22 ` [PATCH 19/73] arm: mach-s3c64xx mach-crag6410-module.c is not modular Paul Gortmaker
2014-01-23 13:16 ` Charles Keepax
2014-02-15 17:04 ` Kukjin Kim [this message]
2014-01-21 21:22 ` [PATCH 20/73] arm: use subsys_initcall in non-modular pl320 IPC code Paul Gortmaker
2014-01-21 21:44 ` Arnd Bergmann
2014-01-21 22:19 ` Paul Gortmaker
2014-01-21 21:22 ` [PATCH 21/73] arm: don't use module_init in non-modular mach-vexpress/spc.c code Paul Gortmaker
2014-01-21 21:22 ` [PATCH 27/73] drivers/clk: don't use module_init in clk-nomadik.c which is non-modular Paul Gortmaker
2014-01-31 23:17 ` Mike Turquette
2014-01-21 21:22 ` [PATCH 28/73] cpuidle: don't use modular platform register in non-modular ARM drivers Paul Gortmaker
2014-01-21 21:22 ` [PATCH 33/73] arm: delete non-required instances of include <linux/init.h> Paul Gortmaker
2014-01-22 7:00 ` [PATCH RFC 00/73] tree-wide: clean up some no longer required #include <linux/init.h> Stephen Rothwell
2014-01-23 0:38 ` Paul Gortmaker
2014-01-28 3:13 ` Benjamin Herrenschmidt
2014-01-28 16:21 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FF9E00.90005@samsung.com \
--to=kgene.kim@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox