From: t-kristo@ti•com (Tero Kristo)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/2] ARM: DTS: OMAP4: Add gpmc_fck clock node
Date: Mon, 17 Feb 2014 14:29:45 +0200 [thread overview]
Message-ID: <530200B9.8090407@ti.com> (raw)
In-Reply-To: <1392636465-31459-3-git-send-email-florian.vaussard@epfl.ch>
On 02/17/2014 01:27 PM, Florian Vaussard wrote:
> Add the gpmc_fck clock, derived from l3_ick, and reference it from
> the GPMC node to get it correctly working.
>
> Signed-off-by: Florian Vaussard <florian.vaussard@epfl•ch>
> ---
> arch/arm/boot/dts/omap4.dtsi | 2 ++
> arch/arm/boot/dts/omap44xx-clocks.dtsi | 6 ++++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
> index d3f8a6e..8a0cc71 100644
> --- a/arch/arm/boot/dts/omap4.dtsi
> +++ b/arch/arm/boot/dts/omap4.dtsi
> @@ -275,6 +275,8 @@
> gpmc,num-waitpins = <4>;
> ti,hwmods = "gpmc";
> ti,no-idle-on-init;
> + clocks = <&gpmc_fck>;
> + clock-names = "fck";
> };
>
> uart1: serial at 4806a000 {
> diff --git a/arch/arm/boot/dts/omap44xx-clocks.dtsi b/arch/arm/boot/dts/omap44xx-clocks.dtsi
> index c821ff5..ae2c441 100644
> --- a/arch/arm/boot/dts/omap44xx-clocks.dtsi
> +++ b/arch/arm/boot/dts/omap44xx-clocks.dtsi
> @@ -1036,6 +1036,12 @@
> ti,index-power-of-two;
> };
>
> + gpmc_fck: gpmc_fck {
> + #clock-cells = <0>;
> + compatible = "ti,clkdm-gate-clock";
> + clocks = <&l3_div_ck>;
> + };
> +
Why not implement a proper gate clock for CM_L3_2_GPMC_CLKCTRL? The
approach you have taken looks good to me otherwise.
-Tero
> gpio2_dbclk: gpio2_dbclk {
> #clock-cells = <0>;
> compatible = "ti,gate-clock";
>
next prev parent reply other threads:[~2014-02-17 12:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 11:27 [PATCH 0/2] ARM: OMAP4: Fix gpmc_fck clock Florian Vaussard
2014-02-17 11:27 ` [PATCH 1/2] CLK: TI: OMAP4: Remove gpmc_fck from dummy clocks Florian Vaussard
2014-02-17 11:27 ` [PATCH 2/2] ARM: DTS: OMAP4: Add gpmc_fck clock node Florian Vaussard
2014-02-17 12:29 ` Tero Kristo [this message]
2014-02-17 16:13 ` Florian Vaussard
2014-02-18 7:27 ` Tero Kristo
2014-02-19 8:39 ` Florian Vaussard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530200B9.8090407@ti.com \
--to=t-kristo@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox