From: voice.shen@atmel•com (Bo Shen)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/2] USB: at91: using USBA_NR_DMAS for DMA channels
Date: Wed, 19 Feb 2014 09:46:31 +0800 [thread overview]
Message-ID: <53040CF7.7060204@atmel.com> (raw)
In-Reply-To: <20140219012252.GA30027@saruman.home>
On 02/19/2014 09:22 AM, Felipe Balbi wrote:
> On Wed, Feb 19, 2014 at 09:14:58AM +0800, Bo Shen wrote:
>> Hi Felipe Balbi,
>>
>> On 02/19/2014 12:19 AM, Felipe Balbi wrote:
>>> On Fri, Jan 17, 2014 at 10:59:25AM +0800, Bo Shen wrote:
>>>> When the SoC is earlier than sama5d3 SoC, which have the same number
>>>> endpoints and DMAs. However for sama5d3 SoC, it has different number
>>>> for endpoints and DMAs. So, define USBA_NR_DMAs for DMA channels
>>>>
>>>> Signed-off-by: Bo Shen <voice.shen@atmel•com>
>>>> ---
>>>>
>>>> drivers/usb/gadget/atmel_usba_udc.c | 2 +-
>>>> drivers/usb/gadget/atmel_usba_udc.h | 2 +-
>>>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/drivers/usb/gadget/atmel_usba_udc.c b/drivers/usb/gadget/atmel_usba_udc.c
>>>> index 7e67a81..5cded1c 100644
>>>> --- a/drivers/usb/gadget/atmel_usba_udc.c
>>>> +++ b/drivers/usb/gadget/atmel_usba_udc.c
>>>> @@ -1661,7 +1661,7 @@ static irqreturn_t usba_udc_irq(int irq, void *devid)
>>>> if (dma_status) {
>>>> int i;
>>>>
>>>> - for (i = 1; i < USBA_NR_ENDPOINTS; i++)
>>>> + for (i = 1; i < USBA_NR_DMAS; i++)
>>>> if (dma_status & (1 << i))
>>>> usba_dma_irq(udc, &udc->usba_ep[i]);
>>>> }
>>>> diff --git a/drivers/usb/gadget/atmel_usba_udc.h b/drivers/usb/gadget/atmel_usba_udc.h
>>>> index 2922db5..a70706e 100644
>>>> --- a/drivers/usb/gadget/atmel_usba_udc.h
>>>> +++ b/drivers/usb/gadget/atmel_usba_udc.h
>>>> @@ -210,7 +210,7 @@
>>>> #define USBA_FIFO_BASE(x) ((x) << 16)
>>>>
>>>> /* Synth parameters */
>>>> -#define USBA_NR_ENDPOINTS 7
>>>> +#define USBA_NR_DMAS 7
>>>
>>> what's the difference ? You just renamed this macro. Also, please
>>> clarify a bit your commit log.
>>
>> As commit message said, the SoC before sama5d3, the endpoint number
>> is the same as DMA channel number, so use endpoints definition for
>> DMA channel number, however after sama5d3, the endpoints is not the
>> same as DMA channel, so use DMA micro for DMA channels.
>
> which means you're just renaming the macro for the sake of clarity.
> That's fine, just needs to be clearer in commit message.
Thanks, I will send v2 to make the commit message more clearer.
Best Regards,
Bo Shen
next prev parent reply other threads:[~2014-02-19 1:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-17 2:59 [PATCH 1/2] USB: at91: fix the number of endpoint parameter Bo Shen
2014-01-17 2:59 ` [PATCH 2/2] USB: at91: using USBA_NR_DMAS for DMA channels Bo Shen
2014-01-17 9:29 ` Nicolas Ferre
2014-02-18 16:19 ` Felipe Balbi
2014-02-19 1:14 ` Bo Shen
2014-02-19 1:22 ` Felipe Balbi
2014-02-19 1:46 ` Bo Shen [this message]
2014-01-17 9:29 ` [PATCH 1/2] USB: at91: fix the number of endpoint parameter Nicolas Ferre
2014-01-18 5:20 ` Jean-Christophe PLAGNIOL-VILLARD
2014-01-20 3:39 ` Bo Shen
2014-01-21 5:49 ` Jean-Christophe PLAGNIOL-VILLARD
2014-01-21 8:12 ` Bo Shen
2014-01-21 9:06 ` Nicolas Ferre
2014-02-07 8:37 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53040CF7.7060204@atmel.com \
--to=voice.shen@atmel$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox