From: tomi.valkeinen@ti•com (Tomi Valkeinen)
To: linux-arm-kernel@lists•infradead.org
Subject: [RFC PATCH v4 3/8] staging: imx-drm: Document updated imx-drm device tree bindings
Date: Thu, 27 Feb 2014 13:06:52 +0200 [thread overview]
Message-ID: <530F1C4C.2010504@ti.com> (raw)
In-Reply-To: <1393338203-25051-4-git-send-email-p.zabel@pengutronix.de>
On 25/02/14 16:23, Philipp Zabel wrote:
> +Freescale i.MX DRM master device
> +================================
> +
> +The freescale i.MX DRM master device is a virtual device needed to list all
> +IPU or other display interface nodes that comprise the graphics subsystem.
> +
> +Required properties:
> +- compatible: Should be "fsl,imx-drm"
> +- ports: Should contain a list of phandles pointing to display interface ports
> + of IPU devices
> +
> +example:
> +
> +imx-drm {
> + compatible = "fsl,imx-drm";
> + ports = <&ipu_di0>;
> +};
I'm not a fan of having non-hardware related things in the DT data.
Especially if it makes direct references to our SW, in this case DRM.
There's no DRM on the board. I wanted to avoid all that with OMAP
display bindings.
Is there even need for such a master device? You can find all the
connected display devices from any single display device, by just
following the endpoint links.
> display at di0 {
> compatible = "fsl,imx-parallel-display";
> edid = [edid-data];
> - crtc = <&ipu 0>;
> interface-pix-fmt = "rgb24";
> +
> + port {
> + display_in: endpoint {
> + remote-endpoint = <&ipu_di0_disp0>;
> + };
> + };
> };
Shouldn't the pix-fmt be defined in the endpoint node? It is about pixel
format for a particular endpoint, isn't it?
> diff --git a/Documentation/devicetree/bindings/staging/imx-drm/ldb.txt b/Documentation/devicetree/bindings/staging/imx-drm/ldb.txt
> index ed93778..578a1fc 100644
> --- a/Documentation/devicetree/bindings/staging/imx-drm/ldb.txt
> +++ b/Documentation/devicetree/bindings/staging/imx-drm/ldb.txt
> @@ -50,12 +50,14 @@ have a look at Documentation/devicetree/bindings/video/display-timing.txt.
>
> Required properties:
> - reg : should be <0> or <1>
> - - crtcs : a list of phandles with index pointing to the IPU display interfaces
> - that can be used as video source for this channel.
> - fsl,data-mapping : should be "spwg" or "jeida"
> This describes how the color bits are laid out in the
> serialized LVDS signal.
> - fsl,data-width : should be <18> or <24>
> + - port: A port node with endpoint definitions as defined in
> + Documentation/devicetree/bindings/media/video-interfaces.txt.
> + On i.MX6, there should be four ports (port@[0-3]) that correspond
> + to the four LVDS multiplexer inputs.
Is the ldb something that's on the imx SoC?
Do you have a public branch somewhere? It'd be easier to look at the
final result, as I'm not familiar with imx.
Tomi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140227/ef94feb6/attachment.sig>
next prev parent reply other threads:[~2014-02-27 11:06 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-25 14:23 [RFC PATCH v4 0/8] imx-drm dt bindings Philipp Zabel
2014-02-25 14:23 ` [RFC PATCH v4 1/8] staging: imx-drm-core: Use OF graph to find components and connections between encoder and crtcs Philipp Zabel
2014-02-25 14:23 ` [RFC PATCH v4 2/8] staging: imx-drm-core: use of_graph_parse_endpoint Philipp Zabel
2014-02-25 14:23 ` [RFC PATCH v4 3/8] staging: imx-drm: Document updated imx-drm device tree bindings Philipp Zabel
2014-02-27 11:06 ` Tomi Valkeinen [this message]
2014-02-27 11:56 ` Russell King - ARM Linux
2014-02-27 13:16 ` Tomi Valkeinen
2014-02-27 13:43 ` Russell King - ARM Linux
2014-02-27 14:10 ` Tomi Valkeinen
2014-03-06 23:42 ` Laurent Pinchart
2014-02-27 13:06 ` Philipp Zabel
2014-02-27 13:00 ` Russell King - ARM Linux
2014-02-27 13:23 ` Rob Clark
2014-02-27 13:55 ` Tomi Valkeinen
2014-02-27 16:54 ` Philipp Zabel
2014-02-28 7:36 ` Tomi Valkeinen
2014-03-04 13:47 ` Philipp Zabel
2014-02-25 14:23 ` [RFC PATCH v4 4/8] staging: imx-drm: Document imx-hdmi " Philipp Zabel
2014-02-25 15:13 ` Fabio Estevam
2014-02-25 18:03 ` Philipp Zabel
2014-02-25 17:32 ` Fabio Estevam
2014-02-25 14:23 ` [RFC PATCH v4 5/8] ARM: dts: imx51: Add IPU ports and endpoints, move imx-drm node to dtsi Philipp Zabel
2014-02-25 14:23 ` [RFC PATCH v4 6/8] ARM: dts: imx53: Add IPU DI " Philipp Zabel
2014-02-25 14:23 ` [RFC PATCH v4 7/8] ARM: dts: imx6qdl: " Philipp Zabel
2014-02-25 14:23 ` [RFC PATCH v4 8/8] staging: imx-drm: Update TODO Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530F1C4C.2010504@ti.com \
--to=tomi.valkeinen@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox