From: santosh.shilimkar@ti•com (Santosh Shilimkar)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] dma: of: Move the functions under CONFIG_OF_DMA instead of CONFIG_OF
Date: Fri, 28 Feb 2014 09:24:27 -0500 [thread overview]
Message-ID: <53109C1B.2030606@ti.com> (raw)
In-Reply-To: <6287295.Q1WPJPjeZV@wuerfel>
On Friday 28 February 2014 04:23 AM, Arnd Bergmann wrote:
> On Thursday 27 February 2014 19:27:03 Santosh Shilimkar wrote:
>>
>> The of-dma.c is compiled out with !CONFIG_DMA_OF but the functions in
>> the header are kept under CONFIG_OF. Move them under CONFIG_OF_DMA
>> to avoid build errors with CONFIG_OFF && !CONFIG_DMA_OF
>>
>> Cc: Grant Likely <grant.likely@linaro•org>
>> Cc: Rob Herring <robh+dt@kernel•org>
>> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti•com>
>
> Sorry, but what is the problem you are seeing with this?
>
> CONFIG_DMA_OF is defined as 'OF && DMAENGINE', and this code
> should only be called from drivers that depend on DMAENGINE.
>
> I'm not saying your patch is wrong, but you shouldn't need it
> unless you do something very odd.
>
So for ARM 'allnoconfig' build we have CONFIG_OF enabled but
CONFIG_DMA_OF disabled. With that the of-dma.c gets compiled
out leaving the functions from of-dma.h undefined. I noticed
this while adding couple of exports in of_dma.h
I am not sure but we added couple of functions for dma-ranges
and dma-coherent which gets called from generic code.
In any case, the patch makes sense since the header and Makefile
are not consistent.
Regards,
Santosh
next prev parent reply other threads:[~2014-02-28 14:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 0:20 [PATCH] dma: of: Move the functions under CONFIG_OF_DMA instead of CONFIG_OF Santosh Shilimkar
2014-02-28 0:27 ` Santosh Shilimkar
2014-02-28 9:23 ` Arnd Bergmann
2014-02-28 14:24 ` Santosh Shilimkar [this message]
2014-02-28 14:47 ` Arnd Bergmann
2014-02-28 15:03 ` Santosh Shilimkar
2014-02-28 15:21 ` Arnd Bergmann
2014-02-28 15:25 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53109C1B.2030606@ti.com \
--to=santosh.shilimkar@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox