From: santosh.shilimkar@ti•com (Santosh Shilimkar)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 5/7] ARM: of: introduce common routine for DMA configuration
Date: Fri, 28 Feb 2014 10:06:25 -0500 [thread overview]
Message-ID: <5310A5F1.9070901@ti.com> (raw)
In-Reply-To: <9618080.kpE3Kl6X8p@wuerfel>
On Friday 28 February 2014 05:00 AM, Arnd Bergmann wrote:
>> diff --git a/drivers/of/platform.c b/drivers/of/platform.c
>> > index 404d1da..97d5533 100644
>> > --- a/drivers/of/platform.c
>> > +++ b/drivers/of/platform.c
>> > @@ -213,10 +213,13 @@ static struct platform_device *of_platform_device_create_pdata(
>> >
>> > #if defined(CONFIG_MICROBLAZE)
>> > dev->archdata.dma_mask = 0xffffffffUL;
>> > -#endif
>> > +#elif defined(CONFIG_ARM_LPAE)
>> > + arm_dt_dma_configure(&dev->dev);
>> > +#else
>> > dev->dev.coherent_dma_mask = DMA_BIT_MASK(32);
>> > if (!dev->dev.dma_mask)
>> > dev->dev.dma_mask = &dev->dev.coherent_dma_mask;
>> > +#endif
> The dependency on CONFIG_ARM_LPAE is not correct the general case,
> that would be a special case on keystone. I'd suggest using
> CONFIG_ARM here, and finding a different way to return false
> for dma_is_coherent() on keystone with LPAE disabled.
>
I made that LPAE specific assuming the 32 machines anyway are
happy with default as they are today. We can keep CONFIG_ARM
and handle the special case in machine platform notifier.
Regards,
Santosh
next prev parent reply other threads:[~2014-02-28 15:06 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 21:17 [PATCH v2 0/7] ARM: dma: Support dma-ranges and dma-coherent Santosh Shilimkar
2014-02-27 21:17 ` [PATCH v2 1/7] ARM: mm: Introduce archdata.dma_pfn_offset Santosh Shilimkar
2014-02-28 9:30 ` Arnd Bergmann
2014-03-05 4:45 ` Linus Walleij
2014-03-05 6:37 ` Santosh Shilimkar
2014-02-27 21:17 ` [PATCH v2 2/7] ARM: mm: Remove unsed dma_to_virt() Santosh Shilimkar
2014-02-28 9:31 ` Arnd Bergmann
2014-03-07 5:59 ` Greg Ungerer
2014-02-27 21:17 ` [PATCH v2 3/7] dma: of: introduce of_dma_get_range() helper Santosh Shilimkar
2014-02-27 21:17 ` [PATCH v2 4/7] dma: of: introduce of_dma_is_coherent() helper Santosh Shilimkar
2014-02-28 9:39 ` Arnd Bergmann
2014-02-28 14:17 ` Santosh Shilimkar
2014-03-03 1:49 ` Catalin Marinas
2014-02-28 15:14 ` Rob Herring
2014-02-28 15:17 ` Santosh Shilimkar
2014-02-28 15:24 ` Arnd Bergmann
2014-03-03 14:04 ` Rob Herring
2014-03-04 15:21 ` Will Deacon
2014-02-27 21:17 ` [PATCH v2 5/7] ARM: of: introduce common routine for DMA configuration Santosh Shilimkar
2014-02-28 10:00 ` Arnd Bergmann
2014-02-28 11:49 ` Grygorii Strashko
2014-02-28 11:14 ` Arnd Bergmann
2014-02-28 15:06 ` Santosh Shilimkar [this message]
2014-02-28 15:31 ` Arnd Bergmann
2014-02-28 15:35 ` Santosh Shilimkar
2014-03-07 3:15 ` Linus Walleij
2014-02-28 14:56 ` Rob Herring
2014-02-27 21:17 ` [PATCH v2 6/7] ARM: dts: keystone: Use dma-ranges property Santosh Shilimkar
2014-02-27 21:17 ` [PATCH v2 7/7] ARM: dts: keystone: Udate USB node for dma properties Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5310A5F1.9070901@ti.com \
--to=santosh.shilimkar@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox