From: sergei.shtylyov@cogentembedded•com (Sergei Shtylyov)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/9] usb: chipidea: usbmisc: Add USB Host support for i.MX25/i.MX35 CPUs
Date: Fri, 07 Mar 2014 22:01:01 +0300 [thread overview]
Message-ID: <531A176D.6090409@cogentembedded.com> (raw)
In-Reply-To: <1394211863-7569-1-git-send-email-denis@eukrea.com>
Hello.
On 03/07/2014 08:04 PM, Denis Carikli wrote:
> Signed-off-by: Denis Carikli <denis@eukrea•com>
> ---
> drivers/usb/chipidea/usbmisc_imx.c | 59 ++++++++++++++++++++++++++++++++++++
> 1 file changed, 59 insertions(+)
> diff --git a/drivers/usb/chipidea/usbmisc_imx.c b/drivers/usb/chipidea/usbmisc_imx.c
> index cd061ab..d956ad0 100644
> --- a/drivers/usb/chipidea/usbmisc_imx.c
> +++ b/drivers/usb/chipidea/usbmisc_imx.c
> @@ -21,6 +21,26 @@
> #define MX25_USB_PHY_CTRL_OFFSET 0x08
> #define MX25_BM_EXTERNAL_VBUS_DIVIDER BIT(23)
>
> +#define MXC_EHCI_INTERFACE_SINGLE_UNI (2 << 0)
> +#define MXC_EHCI_INTERFACE_DIFF_UNI (0 << 0)
> +#define MXC_EHCI_INTERFACE_MASK (0xf)
> +
> +#define MX25_OTG_SIC_SHIFT 29
> +#define MX25_OTG_SIC_MASK (0x3 << MX25_OTG_SIC_SHIFT)
> +#define MX25_OTG_PM_BIT BIT(24)
> +#define MX25_OTG_PP_BIT BIT(11)
> +#define MX25_OTG_OCPOL_BIT (1 << 3)
Hm, why not BIT(3). Though frankly speaking, I don't think (x << n) macros
go together well with BIT() ones.
> +
> +#define MX25_H1_SIC_SHIFT 21
> +#define MX25_H1_SIC_MASK (0x3 << MX25_H1_SIC_SHIFT)
> +#define MX25_H1_PP_BIT BIT(18)
> +#define MX25_H1_PM_BIT BIT(16)
> +#define MX25_H1_IPPUE_UP_BIT BIT(7)
> +#define MX25_H1_IPPUE_DOWN_BIT BIT(6)
> +#define MX25_H1_TLL_BIT BIT(5)
> +#define MX25_H1_USBTE_BIT BIT(4)
> +#define MX25_H1_OCPOL_BIT (1 << 2)
BIT(2)?
WBR, Sergei
next prev parent reply other threads:[~2014-03-07 19:01 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 17:04 [PATCH 1/9] usb: chipidea: usbmisc: Add USB Host support for i.MX25/i.MX35 CPUs Denis Carikli
2014-03-07 17:04 ` [PATCH 2/9] ARM: dts: i.MX51: Add a second usbphy Denis Carikli
2014-03-10 0:52 ` Peter Chen
2014-03-10 4:51 ` Alexander Shiyan
2014-03-10 5:50 ` Peter Chen
2014-03-10 5:58 ` Alexander Shiyan
2014-03-10 6:04 ` Peter Chen
2014-03-07 17:04 ` [PATCH 3/9] ARM: dts: mbimxsd51 baseboard: Add USB host support Denis Carikli
2014-03-07 17:04 ` [PATCH 4/9] ARM: dts: imx25.dtsi: Fix USB support Denis Carikli
2014-03-07 22:57 ` Fabio Estevam
2014-03-07 17:04 ` [PATCH 5/9] ARM: dts: mbimxsd25 baseboard: Add USB host support Denis Carikli
2014-03-07 17:04 ` [PATCH 6/9] ARM: dts: i.MX35: Add USB support Denis Carikli
2014-03-10 1:34 ` Peter Chen
2014-03-10 5:03 ` Shawn Guo
2014-03-07 17:04 ` [PATCH 7/9] ARM: dts: mbimxsd35 baseboard: Add USB host support Denis Carikli
2014-03-07 17:04 ` [PATCH 8/9] ARM: imx_v6_v7_defconfig: Enable drivers for i.MX51 USB Host support Denis Carikli
2014-03-10 1:36 ` Peter Chen
2014-03-07 17:04 ` [PATCH 9/9] ARM: imx_v4_v5_defconfig: Enable drivers for i.MX25/i.MX35 " Denis Carikli
2014-03-10 1:35 ` Peter Chen
2014-03-07 19:01 ` Sergei Shtylyov [this message]
2014-03-08 5:32 ` [PATCH 1/9] usb: chipidea: usbmisc: Add USB Host support for i.MX25/i.MX35 CPUs Alexander Shiyan
2014-03-10 0:40 ` Peter Chen
2014-03-10 1:21 ` Fabio Estevam
2014-03-10 4:58 ` Alexander Shiyan
2014-03-10 11:16 ` Fabio Estevam
2014-03-10 15:32 ` Fabio Estevam
2014-03-10 5:55 ` Eric Bénard
2014-03-10 11:19 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531A176D.6090409@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox