From: t.figa@samsung•com (Tomasz Figa)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v5 2/3] ARM: dts: add dts files for exynos5260 SoC
Date: Thu, 13 Mar 2014 19:32:09 +0100 [thread overview]
Message-ID: <5321F9A9.9030904@samsung.com> (raw)
In-Reply-To: <CAPdUM4McDh5gqk2Z=-n5XTZqsLLVe18rO4s810Zrk0vHQu-M2A@mail.gmail.com>
On 13.03.2014 06:06, Rahul Sharma wrote:
> On 13 March 2014 06:28, Pankaj Dubey <pankaj.dubey@samsung•com> wrote:
>> On 03/13/2014 12:16 AM, Rahul Sharma wrote:
[snip]
>>> + clocks {
>>> + compatible = "simple-bus";
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>
>>
>> Even though you added #address-cells property I can not see "reg" property
>> in any of "fixed-clock".
>> Isn't it better either we can remove this or add "reg" property?
>> Also all these fixed-clock are missing #clock-cells property.
>>
>
> Since it is a soc level addition, I enabled provision for adding reg
> property for
> fixed clocks in boards files (or in SoC file).
>
All sub-nodes should follow the same pattern.
After recent discussion with DT people, the conclusion is that
simple-bus should be used only for MMIO platform devices with "reg"
values mapped directly into address space in which the simple-bus node
resides.
So for now I'd remove the grouping and keep the clocks in "soc" node
directly.
[snip]
>>> +
>>> + dptx_phy_ch0: phyclk_dptx_phy_ch0_txd {
>>> + compatible = "fixed-clock";
>>> + clock-frequency = <270000000>;
>>> + clock-output-names =
>>> "phyclk_dptx_phy_ch0_txd_clk";
>>> + };
I'm not sure whether these clocks are really fixed clocks. They are
output from certain PHY blocks which are not always-on, while using the
fixed clock binding would suggest otherwise. IMHO they should be hidden
inside the clock driver, without DT IDs assigned as a temporary hack,
until proper support gets added for them (e.g. proper clock provider
from appropriate PHY).
Best regards,
Tomasz
next prev parent reply other threads:[~2014-03-13 18:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 15:16 [PATCH v5 0/3] exynos: arch: add support for exynos5260 SoC Rahul Sharma
2014-03-12 15:16 ` [PATCH v5 1/3] ARM: EXYNOS: initial board " Rahul Sharma
2014-03-12 15:16 ` [PATCH v5 2/3] ARM: dts: add dts files " Rahul Sharma
2014-03-13 0:58 ` Pankaj Dubey
2014-03-13 5:06 ` Rahul Sharma
2014-03-13 18:32 ` Tomasz Figa [this message]
2014-03-13 15:33 ` Tomasz Figa
2014-03-12 15:16 ` [PATCH v5 3/3] ARM: dts: add dts files for xyref5260 board Rahul Sharma
2014-03-13 0:49 ` Pankaj Dubey
2014-03-13 5:01 ` Rahul Sharma
2014-03-13 6:12 ` Rahul Sharma
2014-03-13 18:38 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5321F9A9.9030904@samsung.com \
--to=t.figa@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox