From: antoine.tenart@free-electrons•com (Antoine Ténart)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 1/3] ARM: dts: berlin2q: add the Marvell Armada 1500 pro
Date: Fri, 14 Mar 2014 10:48:57 +0100 [thread overview]
Message-ID: <5322D089.7010605@free-electrons.com> (raw)
In-Reply-To: <5322CC8B.6010905@gmail.com>
Sebastian,
On 14/03/2014 10:31, Sebastian Hesselbarth wrote:
> On 03/13/2014 03:06 PM, Antoine T?nart wrote:
>> + clocks {
>> + #address-cells = <0>;
>> + #size-cells = <0>;
>> +
>> + smclk: sysmgr-clock {
>> + compatible = "fixed-clock";
>> + #clock-cells = <0>;
>> + clock-frequency = <25000000>;
>> + };
>> +
>> + sysclk: system-clock {
>> + compatible = "fixed-clock";
>> + #clock-cells = <0>;
>> + clock-frequency = <400000000>;
>> + };
>> + };
>> +
>> + soc {
> [...]
>> + local-timer at ad0600 {
>> + compatible = "arm,cortex-a9-twd-timer";
>> + reg = <0xad0600 0x20>;
>> + clocks = <&sysclk>;
>
> If I understand Jisheng correctly, this should be cpuclk/3. When
> removing the clocks {} container above, please also take care of
> it.
>
> You can do
>
> cpuclk: cpu-clock {
> compatible = "fixed-clock";
> #clock-cells = <0>;
> clock-frequency = <1200000000>; /* <- put correct freq here */
> };
>
> sysclk: system-clock {
> compatible = "fixed-factor-clock";
> #clock-cells = <0>;
> clocks = <&cpuclk>;
> clock-multi = <1>;
> clock-div = <3>;
> };
>
> Hopefully, we'll have proper clock drivers soon so we can just replace
> referenced "fixed-*" clocks.
Sure, this is why I only kept one fixed clock in this patch.
I'll add the cpuclk here then.
>> + timer0: timer at 2c00 {
>> + compatible = "snps,dw-apb-timer";
>> + reg = <0x2c00 0x14>;
>> + interrupts = <8>;
>> + clock-freq = <100000000>;
>> + status = "okay";
>> + };
>> +
>> + timer1: timer at 2c14 {
>> + compatible = "snps,dw-apb-timer";
>> + reg = <0x2c14 0x14>;
>> + clock-freq = <100000000>;
>> + status = "disabled";
>> + };
>
> Please also add the remaining 6 apb timers.
I don't have any information about the remaining 6 apb timers. I'll ask
Jisheng.
Antoine
--
Antoine T?nart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-03-14 9:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 14:06 [PATCH v2 0/3] ARM: add initial support for the Marvell BG2-Q DMP Antoine Ténart
2014-03-13 14:06 ` [PATCH v2 1/3] ARM: dts: berlin2q: add the Marvell Armada 1500 pro Antoine Ténart
2014-03-13 17:25 ` Mark Rutland
2014-03-14 9:31 ` Sebastian Hesselbarth
2014-03-14 9:48 ` Antoine Ténart [this message]
2014-03-14 9:53 ` Sebastian Hesselbarth
2014-03-14 11:32 ` Alexandre Belloni
2014-03-14 11:36 ` Sebastian Hesselbarth
2014-03-13 14:06 ` [PATCH v2 2/3] ARM: berlin2q: add the Marvell Armada 1500 pro in the documentation Antoine Ténart
2014-03-13 14:06 ` [PATCH v2 3/3] ARM: dts: berlin2q: add the Marvell BG2-Q DMP device tree Antoine Ténart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5322D089.7010605@free-electrons.com \
--to=antoine.tenart@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox