From: grygorii.strashko@ti•com (Grygorii Strashko)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2] gpio: davinci: fix gpio selection for OF
Date: Mon, 17 Mar 2014 17:04:24 +0200 [thread overview]
Message-ID: <53270EF8.6020908@ti.com> (raw)
In-Reply-To: <5326F8C5.5090406@ti.com>
On 03/17/2014 03:29 PM, Sekhar Nori wrote:
> On Friday 14 March 2014 04:32 PM, Linus Walleij wrote:
>> On Fri, Mar 14, 2014 at 11:08 AM, Alexander Holler <holler@ahsoftware•de> wrote:
>>> Am 11.03.2014 11:15, schrieb Linus Walleij:
>>>> On Wed, Mar 5, 2014 at 12:21 PM, Alexander Holler <holler@ahsoftware•de> wrote:
>>>>
>>>>> The driver missed an of_xlate function to translate gpio numbers
>>>>> as found in the DT to the correct chip and number.
>>>>>
>>>>> While there I've set #gpio_cells to a fixed value of 2.
>>>>>
>>>>> I've used gpio-pxa.c as template for those changes and tested my changes
>>>>> successfully on a da850 board using entries for gpio-leds in a DT. So I didn't
>>>>> reinvent the wheel but just copied and tested stuff.
>>>>>
>>>>> Thanks to Grygorii Strashko for the hint to the existing code in gpio-pxa.
>>>>>
>>>>> Signed-off-by: Alexander Holler <holler@ahsoftware•de>
>>>>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti•com>
>>>>
>>>> This v2 version applied, thanks!
>>>
>>> Thanks, but actually that should have been a fix for 3.14 with which the
>>> OF functionality for davinci gpio gets introduced. I assum with the
>>> patch in for-next, 3.14 will appear with that functionality broken and
>>> it will become a candidate for -stable.
>>
>> I just get the impression that DT support for DaVinci in v3.14 is so risky
>> and unstable that noone except those implementing it (i.e. you) is really
>> using it, is that correct?
>>
>> In that case it is hardly a fix that we need to rush out to the entire world.
>
> One thing to note is that this driver is used by keystone too and all
> its users are DT-only. Although I do not see any in-kernel DT GPIO users
> even there.
>
> I can confirm the patch does not break my gpiolib based test module
> (test with and without DT), but then it did not have an issue even before.
The issues isn't observed on Keystone2 as it has <32 gpios as of now, also GPIO
support for keystone is going to be added in 3.15 (including DT changes).
Regards,
-grygorii
prev parent reply other threads:[~2014-03-17 15:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5315ED51.1000006@ti.com>
2014-03-04 22:06 ` [PATCH] gpio: davinci: fix gpio selection for OF Alexander Holler
2014-03-05 2:27 ` Linus Walleij
2014-03-05 10:43 ` Grygorii Strashko
2014-03-05 11:21 ` [PATCH v2] " Alexander Holler
2014-03-05 13:12 ` Grygorii Strashko
2014-03-11 10:15 ` Linus Walleij
2014-03-14 10:08 ` Alexander Holler
2014-03-14 11:02 ` Linus Walleij
2014-03-14 12:38 ` Alexander Holler
2014-03-14 13:54 ` Linus Walleij
2014-03-14 18:33 ` Alexander Holler
2014-03-14 19:52 ` Linus Walleij
2014-03-15 7:37 ` Alexander Holler
2014-03-17 13:29 ` Sekhar Nori
2014-03-17 14:05 ` Linus Walleij
2014-03-18 8:37 ` Sekhar Nori
2014-03-18 9:45 ` Alexander Holler
2014-03-18 10:54 ` Sekhar Nori
2014-03-21 8:28 ` Linus Walleij
2014-03-21 8:59 ` Alexander Holler
2014-03-17 14:11 ` Alexander Holler
2014-03-17 14:13 ` Linus Walleij
2014-03-17 15:04 ` Grygorii Strashko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53270EF8.6020908@ti.com \
--to=grygorii.strashko@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox