From: t.figa@samsung•com (Tomasz Figa)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v11 10/27] iommu/exynos: use managed device helper functions
Date: Tue, 18 Mar 2014 16:12:27 +0100 [thread overview]
Message-ID: <5328625B.508@samsung.com> (raw)
In-Reply-To: <20140318193817.3448387b75e109e814b9c025@samsung.com>
On 18.03.2014 11:38, Cho KyongHo wrote:
> On Fri, 14 Mar 2014 14:28:36 +0100, Tomasz Figa wrote:
>> Hi KyongHo,
>>
>> On 14.03.2014 06:05, Cho KyongHo wrote:
>>> This patch uses managed device helper functions in the probe().
>>>
>>> Signed-off-by: Cho KyongHo <pullip.cho@samsung•com>
>>> ---
>>> drivers/iommu/exynos-iommu.c | 64 +++++++++++++++++-------------------------
>>> 1 file changed, 26 insertions(+), 38 deletions(-)
>>>
>>> diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c
>>> index 36e6b73..33b424d 100644
>>> --- a/drivers/iommu/exynos-iommu.c
>>> +++ b/drivers/iommu/exynos-iommu.c
>>> @@ -499,51 +499,48 @@ void exynos_sysmmu_tlb_invalidate(struct device *dev)
>>>
>>> static int exynos_sysmmu_probe(struct platform_device *pdev)
>>> {
>>> - int ret;
>>> + int irq, ret;
>>> struct device *dev = &pdev->dev;
>>> struct sysmmu_drvdata *data;
>>> struct resource *res;
>>>
>>> - data = kzalloc(sizeof(*data), GFP_KERNEL);
>>> - if (!data) {
>>> - dev_dbg(dev, "Not enough memory\n");
>>> - ret = -ENOMEM;
>>> - goto err_alloc;
>>> - }
>>> + data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
>>> + if (!data)
>>> + return -ENOMEM;
>>>
>>> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>>> if (!res) {
>>> - dev_dbg(dev, "Unable to find IOMEM region\n");
>>> - ret = -ENOENT;
>>> - goto err_init;
>>> + dev_err(dev, "Unable to find IOMEM region\n");
>>> + return -ENOENT;
>>> }
>>
>> No need to check for error and print message, because
>> devm_ioremap_resource() already checks the passed resource and handles
>> error cases.
>>
>
> Yes but devm_ioremap_resource() just tells that the given 'res' is not
> correct. I think the message in the driver is more informative.
The common practice used in Linux kernel is to not duplicate such
messages. It is obvious that devm_ioremap_resource() printing such
message is related to an IOMEM resource anyway, as you can't used it
with other types of resources.
Best regards,
Tomasz
next prev parent reply other threads:[~2014-03-18 15:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-14 5:05 [PATCH v11 10/27] iommu/exynos: use managed device helper functions Cho KyongHo
2014-03-14 13:28 ` Tomasz Figa
2014-03-18 10:38 ` Cho KyongHo
2014-03-18 15:12 ` Tomasz Figa [this message]
2014-03-18 23:59 ` Jingoo Han
2014-03-19 8:56 ` Cho KyongHo
2014-03-14 15:22 ` Sachin Kamat
2014-03-18 11:09 ` Cho KyongHo
2014-03-18 15:14 ` Tomasz Figa
2014-03-19 8:59 ` Cho KyongHo
2014-03-19 9:01 ` Sachin Kamat
2014-03-19 12:08 ` Tomasz Figa
2014-03-20 10:03 ` Cho KyongHo
2014-03-20 10:44 ` Tomasz Figa
2014-03-21 4:49 ` Cho KyongHo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5328625B.508@samsung.com \
--to=t.figa@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox