From: t.figa@samsung•com (Tomasz Figa)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v11 19/27] iommu/exynos: add support for power management subsystems.
Date: Tue, 18 Mar 2014 16:33:04 +0100 [thread overview]
Message-ID: <53286730.1060807@samsung.com> (raw)
In-Reply-To: <20140318202320.a3101304bbc51cc9f169cdaa@samsung.com>
On 18.03.2014 12:23, Cho KyongHo wrote:
> On Fri, 14 Mar 2014 17:07:53 +0100, Tomasz Figa wrote:
>> Hi KyongHo,
>>
>> On 14.03.2014 06:10, Cho KyongHo wrote:
[snip]
>>> @@ -677,11 +679,40 @@ static int __init exynos_sysmmu_probe(struct platform_device *pdev)
>>> platform_set_drvdata(pdev, data);
>>>
>>> pm_runtime_enable(dev);
>>> + data->runtime_active = !pm_runtime_enabled(dev);
>>
>> Hmm, this seems to be a bit misleading. The field is named
>> runtime_active, but the assignment makes it true if PM runtime is _not_
>> enabled (i.e. inactive). Is this correct?
>>
>
> I agree that it may lead misunderstood.
> data->runtime_active actually indicates if electric power is asserted
> to the System MMU. pm_runtime_enable() call must enable runtime pm
> for the given device. If runtime pm is not enabled although pm_runtime_enable()
> is called, CONFIG_PM_RUNTIME is not configured.
>
> Actually, it is replacible with
> if (IS_ENABLED(CONFIG_PM_RUNTIME))
> data->runtime_active = true;
I would keep it as !pm_runtime_enabled(dev), but rename the field to
something more meaningful, like data->is_powered_on.
Best regards,
Tomasz
next prev parent reply other threads:[~2014-03-18 15:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-14 5:10 [PATCH v11 19/27] iommu/exynos: add support for power management subsystems Cho KyongHo
2014-03-14 16:07 ` Tomasz Figa
2014-03-18 11:23 ` Cho KyongHo
2014-03-18 15:33 ` Tomasz Figa [this message]
2014-03-19 9:07 ` Cho KyongHo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53286730.1060807@samsung.com \
--to=t.figa@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox