From: t.figa@samsung•com (Tomasz Figa)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/2] serial: s3c: Fix build of header without serial_core.h preinclusion
Date: Tue, 18 Mar 2014 18:30:47 +0100 [thread overview]
Message-ID: <532882C7.8060701@samsung.com> (raw)
In-Reply-To: <1395143803-2032-1-git-send-email-broonie@kernel.org>
Hi Mark,
On 18.03.2014 12:56, Mark Brown wrote:
> From: Mark Brown <broonie@linaro•org>
>
> serial_s3c.h uses upf_t which is defined in serial_core.h but does not
> include that itself meaning that users which include serial_s3c.h by
> itself don't build.
>
> Signed-off-by: Mark Brown <broonie@linaro•org>
> ---
>
> This is needed together with patch 2 to fix build failures in -next, I
> didn't have the time/enthusiasm to isolate the issue.
>
> include/linux/serial_s3c.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/serial_s3c.h b/include/linux/serial_s3c.h
> index 907d9d1d56cf..44e4a6b92ddb 100644
> --- a/include/linux/serial_s3c.h
> +++ b/include/linux/serial_s3c.h
> @@ -29,6 +29,8 @@
> #ifndef __ASM_ARM_REGS_SERIAL_H
> #define __ASM_ARM_REGS_SERIAL_H
>
> +#include <linux/serial_core.h>
> +
> #define S3C2410_URXH (0x24)
> #define S3C2410_UTXH (0x20)
> #define S3C2410_ULCON (0x00)
>
Thanks for fixing this up. However due to this header ending up being
included by arch/arm/kernel/debug.S, this breaks mach-exynos. I have
fixed this up by moving the inclusion down the file, under #ifndef
__ASSEMBLY__ and posted next version along with other fixups.
Best regards,
Tomasz
prev parent reply other threads:[~2014-03-18 17:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 11:56 [PATCH 1/2] serial: s3c: Fix build of header without serial_core.h preinclusion Mark Brown
2014-03-18 11:56 ` [PATCH 2/2] ARM: s3c64xx: Fix build for implicit serial_s3c.h inclusion Mark Brown
2014-03-20 17:56 ` Kukjin Kim
2014-03-18 17:30 ` Tomasz Figa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532882C7.8060701@samsung.com \
--to=t.figa@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox