From: t.figa@samsung•com (Tomasz Figa)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v11 17/27] iommu/exynos: remove calls to Runtime PM API functions
Date: Wed, 19 Mar 2014 18:30:14 +0100 [thread overview]
Message-ID: <5329D426.9020706@samsung.com> (raw)
In-Reply-To: <CANEJEGuYz28dGT+264CYtG+Tk6htOq=u-t4PWMtsij32X0vJFA@mail.gmail.com>
Hi Grant,
On 19.03.2014 18:03, Grant Grundler wrote:
> On Wed, Mar 19, 2014 at 6:12 AM, Tomasz Figa <t.figa@samsung•com> wrote:
> ...
>> No. Proper Linux drivers must support deferred probing mechanism and there
>> should be no assumptions about probing orders. Using other initcall level
>> than module_initcall for particular drivers is strongly discouraged.
>
> That's true for "end-point" devices. It's not true for
> "infrastructure": Memory, CPU, DMA, Interrupt handling, etc. Those
> need to be in place before "normal" drivers get called. This SysMMU
> driver provides DMA services for "normal" device drivers. Or do I see
> that wrong?
Of course using an early initcall level would give you some kind of
guarantees, but it wouldn't guarantee that someone couldn't lower
initcall level for some MMU client driver and break the ordering anyway.
As I said, AFAIK the trend is to get rid of ordering by initcalls and
make sure that drivers can handle missing dependencies properly, even
for "services" such as DMA, GPIO, clocks and so on, which after all are
provided by normal drivers like other.
>
> thanks,
> grant
>
> ps. I've written IOMMU support for four different IOMMUs on three
> operating systems (See drivers/parisc for two linux examples). But I
> still feel like I at best have 80% understanding of how this one is
> organized/works. Abstract descriptions and convoluted code have been
> handicapping me (and lack of time to dig further).
Well, this is one of my concerns with this driver. It isn't easy to read
(and so review, maintain, extend and debug found issues).
Best regards,
Tomasz
next prev parent reply other threads:[~2014-03-19 17:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-14 5:08 [PATCH v11 17/27] iommu/exynos: remove calls to Runtime PM API functions Cho KyongHo
2014-03-14 12:59 ` Tomasz Figa
2014-03-18 9:56 ` Cho KyongHo
2014-03-18 15:09 ` Tomasz Figa
2014-03-19 1:03 ` Cho KyongHo
2014-03-19 13:12 ` Tomasz Figa
2014-03-19 16:54 ` Grant Grundler
2014-03-20 11:55 ` Cho KyongHo
2014-03-19 17:03 ` Grant Grundler
2014-03-19 17:30 ` Tomasz Figa [this message]
2014-03-19 18:37 ` Grant Grundler
2014-03-19 18:51 ` Tomasz Figa
2014-03-20 12:07 ` Cho KyongHo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5329D426.9020706@samsung.com \
--to=t.figa@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox