From: kgene.kim@samsung•com (Kukjin Kim)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 1/6] serial: s3c: Fix build of header without serial_core.h preinclusion
Date: Fri, 21 Mar 2014 02:52:31 +0900 [thread overview]
Message-ID: <532B2ADF.1000207@samsung.com> (raw)
In-Reply-To: <1395162964-5916-1-git-send-email-t.figa@samsung.com>
On 03/19/14 02:15, Tomasz Figa wrote:
> From: Mark Brown<broonie@linaro•org>
>
> serial_s3c.h uses upf_t which is defined in serial_core.h but does not
> include that itself meaning that users which include serial_s3c.h by
> itself don't build.
>
Oops yeah, When we replace inclusion of <plat/regs-serial.h> with
serial_s3c.h, maybe we missed inclusion of serial_core.h in the
following files:
arch/arm/include/debug/samsung.S
arch/arm/mach-s3c24xx/include/mach/debug-macro.S
arch/arm/mach-s3c24xx/mach-s3c2416-dt.c
arch/arm/mach-s3c24xx/mach-vr1000.c
arch/arm/mach-s3c24xx/sleep-s3c2410.S
arch/arm/mach-s3c24xx/sleep.S
arch/arm/mach-s3c64xx/include/mach/debug-macro.S
arch/arm/mach-s5p64x0/include/mach/debug-macro.S
arch/arm/mach-s5pc100/include/mach/debug-macro.S
arch/arm/mach-s5pv210/include/mach/debug-macro.S
So, this fix looks good to me. BTW, we need to cleanup inclusion of
serial_core.h later because it is useless with this.
Applied, thanks.
- Kukjin
> Signed-off-by: Mark Brown<broonie@linaro•org>
> [t.figa: Moved inclusion under #ifndef __ASSEMBLY__ to fix mach-exynos.]
> Signed-off-by: Tomasz Figa<t.figa@samsung•com>
> ---
> include/linux/serial_s3c.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/serial_s3c.h b/include/linux/serial_s3c.h
> index 907d9d1..e6fc956 100644
> --- a/include/linux/serial_s3c.h
> +++ b/include/linux/serial_s3c.h
> @@ -233,6 +233,8 @@
>
> #ifndef __ASSEMBLY__
>
> +#include<linux/serial_core.h>
> +
> /* configuration structure for per-machine configurations for the
> * serial port
> *
prev parent reply other threads:[~2014-03-20 17:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 17:15 [PATCH v2 1/6] serial: s3c: Fix build of header without serial_core.h preinclusion Tomasz Figa
2014-03-18 17:16 ` [PATCH v2 2/6] ARM: s3c64xx: Fix build for implicit serial_s3c.h inclusion Tomasz Figa
2014-03-18 17:16 ` [PATCH v2 3/6] ARM: EXYNOS: Fix compilation error in cpuidle.c Tomasz Figa
2014-03-20 18:01 ` Kukjin Kim
2014-03-18 17:16 ` [PATCH v2 4/6] ARM: SAMSUNG: Fix rebase error in pm-debug.c Tomasz Figa
2014-03-20 18:08 ` Kukjin Kim
2014-03-18 17:16 ` [PATCH v2 5/6] ARM: s3c64xx: Fix incorrect selection of PM-related symbols Tomasz Figa
2014-03-20 18:20 ` Kukjin Kim
2014-03-18 17:16 ` [PATCH v2 6/6] ARM: s5p64x0: Explicitly include linux/serial_s3c.h in mach/pm-core.h Tomasz Figa
2014-03-20 18:35 ` Kukjin Kim
2014-03-20 17:52 ` Kukjin Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532B2ADF.1000207@samsung.com \
--to=kgene.kim@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox