From: marc.zyngier@arm•com (Marc Zyngier)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 02/19] arm64: initial support for GICv3
Date: Tue, 25 Mar 2014 07:33:46 +0000 [thread overview]
Message-ID: <5331315A.9010001@arm.com> (raw)
In-Reply-To: <CABg9mcucJ_UouRbJ_Urirz6ita5uUvYuQkmeA1-Df00KSjFcnA@mail.gmail.com>
On 25/03/14 06:35, Z Lim wrote:
> Hi Marc,
>
> On Mon, Mar 24, 2014 at 4:10 AM, Marc Zyngier <marc.zyngier@arm•com
> <mailto:marc.zyngier@arm•com>> wrote:
>>
>> Hi Zi,
>>
>> On 22/03/14 01:21, Zi Shen Lim wrote:
>> > Hi Marc,
>> >
>> > On Thu, Mar 20, 2014 at 4:52 AM, Marc Zyngier <marc.zyngier@arm•com
> <mailto:marc.zyngier@arm•com>
>> > <mailto:marc.zyngier at arm.com <mailto:marc.zyngier@arm•com>>> wrote:
>> > <snip>
>> >
>> >
>> > + /*
>> > + * Find out how many interrupts are supported.
>> > + * The GIC only supports up to 1020 interrupt sources
>> > (SGI+PPI+SPI)
>> > + */
>> > + gic_irqs = readl_relaxed(gic_data.dist_base + GICD_TYPER) &
>> > 0x1f;
>> > + gic_irqs = (gic_irqs + 1) * 32;
>> > + if (gic_irqs > 1020)
>> > + gic_irqs = 1020;
>> > + gic_data.irq_nr = gic_irqs;
>> > +
>> > + gic_data.domain = irq_domain_add_linear(node, gic_irqs - 16,
>> > + &gic_irq_domain_ops,
>> > &gic_data);
>> >
>> >
>> > Why gic_irqs - 16?
>>
>> Because we keep the SGIs (all 16 of them) for the core kernel (drivers
>> are not allowed to request them).
>>
>> >
>> > __irq_domain_add(of_node, size, size, 0, ops, host_data);
>> >
>> > domain->hwirq_max = hwirq_max;
>> >
>> >
>> > So hwirq_max is effectively set to actual_hwirq_max-16.
>> >
>> > Later, the following warning can be triggered:
>> >
>> > int irq_domain_associate(struct irq_domain *domain, unsigned int
> virq,
>> > irq_hw_number_t hwirq)
>> > {
>> > struct irq_data *irq_data = irq_get_irq_data(virq);
>> > int ret;
>> >
>> > if (WARN(hwirq >= domain->hwirq_max,
>> > "error: hwirq 0x%x is too large for %s\n",
>> > (int)hwirq, domain->name))
>> > return -EINVAL;
>>
>> Do you actually see this warning being triggered? I don't. We're using a
>> linear domain that doesn't call into this function.
>
> I see this warning :(
> You can trigger it when a device's INT# falls within [gic_irqs-16,
> gic_irqs), which lines up with the -16 above.
Ah, got you. Hmmm. I may have to be slightly more creative then.
Thanks a lot for the report, I'll fix that as quickly as possible.
Cheers,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2014-03-25 7:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 11:52 [PATCH v2 00/19] arm64: GICv3 support Marc Zyngier
2014-03-20 11:52 ` [PATCH v2 01/19] ARM: GIC: move some bits of GICv2 to a library-type file Marc Zyngier
2014-03-20 11:52 ` [PATCH v2 02/19] arm64: initial support for GICv3 Marc Zyngier
[not found] ` <CAMDttNew0S7xVVKge7AAR3W6bdQzKdvN9Z7cHPDUCq=jZ98q1A@mail.gmail.com>
2014-03-24 11:10 ` Marc Zyngier
[not found] ` <CABg9mcucJ_UouRbJ_Urirz6ita5uUvYuQkmeA1-Df00KSjFcnA@mail.gmail.com>
2014-03-25 7:33 ` Marc Zyngier [this message]
2014-03-25 10:13 ` Marc Zyngier
[not found] ` <CABg9mcsWrjsBaDbk0fdJPJdzhQ6jmgZOkDNG0_r7ZbWzcCdb0A@mail.gmail.com>
2014-03-25 19:29 ` Marc Zyngier
2014-03-24 19:03 ` Sudeep Holla
2014-03-24 19:07 ` Marc Zyngier
2014-03-20 11:52 ` [PATCH v2 03/19] arm64: GICv3 device tree binding documentation Marc Zyngier
2014-03-20 11:52 ` [PATCH v2 04/19] arm64: boot protocol documentation update for GICv3 Marc Zyngier
2014-03-20 11:52 ` [PATCH v2 05/19] KVM: arm/arm64: vgic: move GICv2 registers to their own structure Marc Zyngier
2014-03-20 11:52 ` [PATCH v2 06/19] KVM: ARM: vgic: introduce vgic_ops and LR manipulation primitives Marc Zyngier
2014-03-20 11:52 ` [PATCH v2 07/19] KVM: ARM: vgic: abstract access to the ELRSR bitmap Marc Zyngier
2014-03-20 11:52 ` [PATCH v2 08/19] KVM: ARM: vgic: abstract EISR bitmap access Marc Zyngier
2014-03-20 11:52 ` [PATCH v2 09/19] KVM: ARM: vgic: abstract MISR decoding Marc Zyngier
2014-03-20 11:52 ` [PATCH v2 10/19] KVM: ARM: vgic: move underflow handling to vgic_ops Marc Zyngier
2014-03-20 11:52 ` [PATCH v2 11/19] KVM: ARM: vgic: abstract VMCR access Marc Zyngier
2014-03-20 11:52 ` [PATCH v2 12/19] KVM: ARM: vgic: introduce vgic_enable Marc Zyngier
2014-03-20 11:53 ` [PATCH v2 13/19] KVM: ARM: introduce vgic_params structure Marc Zyngier
2014-03-20 11:53 ` [PATCH v2 14/19] KVM: ARM: vgic: split GICv2 backend from the main vgic code Marc Zyngier
2014-03-20 11:53 ` [PATCH v2 15/19] arm64: KVM: remove __kvm_hyp_code_{start, end} from hyp.S Marc Zyngier
2014-03-20 11:53 ` [PATCH v2 16/19] arm64: KVM: split GICv2 world switch from hyp code Marc Zyngier
2014-03-20 11:53 ` [PATCH v2 17/19] arm64: KVM: move hcr_el2 setting into vgic-v2-switch.S Marc Zyngier
2014-03-20 11:53 ` [PATCH v2 18/19] KVM: ARM: vgic: add the GICv3 backend Marc Zyngier
2014-03-20 11:53 ` [PATCH v2 19/19] arm64: KVM: vgic: add GICv3 world switch Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5331315A.9010001@arm.com \
--to=marc.zyngier@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox