Subject: Re: [arm-platforms:irq/irqchip-next 5/28] drivers/gpio/gpio-sifive.c:83:2: error: implicit declaration of function 'irq_chip_enable_parent'; did you mean 'gpiochip_enable_irq'?

From: Marc Zyngier <[email-masked]>
Date: Mon, 20 Jan 2020 19:09:35 +0000

Yash,

On 2020-01-20 18:59, kbuild test robot wrote:
> tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git
> irq/irqchip-next
> head:   c7f5b05c27a8501dc5a88bab49b6010e375e91f8
> commit: cd2abc8e87fef699d0da106103b65f6ca8dcbfe7 [5/28] gpio/sifive:
> Add GPIO driver for SiFive SoCs
> config: c6x-randconfig-a001-20200121 (attached as .config)
> compiler: c6x-elf-gcc (GCC) 7.5.0
> reproduce:
>         wget
> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
> -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout cd2abc8e87fef699d0da106103b65f6ca8dcbfe7
>         # save the attached .config to linux build tree
>         GCC_VERSION=7.5.0 make.cross ARCH=c6x
> 
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <[email-masked]>
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/gpio/gpio-sifive.c: In function 'sifive_gpio_irq_enable':
>>> drivers/gpio/gpio-sifive.c:83:2: error: implicit declaration of 
>>> function 'irq_chip_enable_parent'; did you mean 
>>> 'gpiochip_enable_irq'? [-Werror=implicit-function-declaration]
>      irq_chip_enable_parent(d);

[...]

This is how I'm planning to fix this (at least for the time
being, as I don't want to break -next at this stage).

Let me know if you want to address it otherwise.

Thanks,

         M.

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 6c63b79069f2..809dd54a2e82 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -481,7 +481,7 @@ config GPIO_SAMA5D2_PIOBU

  config GPIO_SIFIVE
         bool "SiFive GPIO support"
-       depends on OF_GPIO
+       depends on OF_GPIO && IRQ_DOMAIN_HIERARCHY
         select GPIO_GENERIC
         select GPIOLIB_IRQCHIP
         select REGMAP_MMIO

-- 
Jazz is not dead. It just smells funny...

_______________________________________________
linux-arm-kernel mailing list
[email-masked]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel