From: voice.shen@atmel•com (Bo Shen)
To: linux-arm-kernel@lists•infradead.org
Subject: [alsa-devel] [RFC v2 PATCH] ASoC: wm8904: add CCF support
Date: Wed, 26 Mar 2014 09:32:25 +0800 [thread overview]
Message-ID: <53322E29.3070000@atmel.com> (raw)
In-Reply-To: <20140325112716.GS2269@sirena.org.uk>
Hi Mark,
On 03/25/2014 07:27 PM, Mark Brown wrote:
> On Tue, Mar 25, 2014 at 05:56:56PM +0800, Bo Shen wrote:
>
>> case SND_SOC_BIAS_ON:
>> + if (IS_ENABLED(CONFIG_COMMON_CLK))
>> + if (wm8904->mclk)
>> + clk_prepare_enable(wm8904->mclk);
>
> No, this shouldn't depend on COMMON_CLK - there is no reason other clock
> API implementations shouldn't be able to use this. Providing a clock is
> something you can only do with COMMON_CLK but using one doesn't need
> that, generally using a clock is done unconditionally.
Actually in probe function, it does this check, if not CCF support, the
wm8904->mclk is NULL. So, we can remove the CCF check here.
Thanks.
Best Regards,
Bo Shen
next prev parent reply other threads:[~2014-03-26 1:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-25 9:56 [RFC v2 PATCH] ASoC: wm8904: add CCF support Bo Shen
2014-03-25 11:27 ` Mark Brown
2014-03-26 1:32 ` Bo Shen [this message]
2014-03-25 11:59 ` Boris BREZILLON
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53322E29.3070000@atmel.com \
--to=voice.shen@atmel$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox