From: s.nawrocki@samsung•com (Sylwester Nawrocki)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] clk: reverse default clk provider initialization order in of_clk_init()
Date: Thu, 27 Mar 2014 11:49:34 +0100 [thread overview]
Message-ID: <5334023E.8070101@samsung.com> (raw)
In-Reply-To: <1395917012-23483-1-git-send-email-s.nawrocki@samsung.com>
On 27/03/14 11:43, Sylwester Nawrocki wrote:
> This restores the default clocks registration order as parsed from
> devicetree, i.e. as before commit 1771b10d605d26ccee771a7fb4b08718
> "clk: respect the clock dependencies in of_clk_init", for when there
> is no explicit parent clock dependencies between clock providers
> specified in the device tree.
>
> It prevents regressions (boot failure, division by 0 errors) on
> imx and exynos platforms.
>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung•com>
Oops, I've forgotten to add:
Tested-by: Fabio Estevam <fabio.estevam@freescale•com>
> ---
> drivers/clk/clk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index 07cba07..c859adf 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -2596,7 +2596,7 @@ void __init of_clk_init(const struct of_device_id *matches)
>
> parent->clk_init_cb = match->data;
> parent->np = np;
> - list_add(&parent->node, &clk_provider_list);
> + list_add_tail(&parent->node, &clk_provider_list);
> }
>
> while (!list_empty(&clk_provider_list)) {
--
Regards,
Sylwester
next prev parent reply other threads:[~2014-03-27 10:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 10:43 [PATCH] clk: reverse default clk provider initialization order in of_clk_init() Sylwester Nawrocki
2014-03-27 10:49 ` Sylwester Nawrocki [this message]
2014-03-29 8:41 ` Mike Turquette
2014-03-31 15:00 ` Kevin Hilman
2014-03-31 17:05 ` Mike Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5334023E.8070101@samsung.com \
--to=s.nawrocki@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox