From: sudeep.holla@arm•com (Sudeep Holla)
To: linux-arm-kernel@lists•infradead.org
Subject: [Linaro-acpi] [PATCH v4 1/3] PSCI: Add initial support for PSCIv0.2 functions
Date: Mon, 31 Mar 2014 19:25:34 +0100 [thread overview]
Message-ID: <5339B31E.5090406@arm.com> (raw)
In-Reply-To: <CAJ5Y-eafEJz487nwg6MRPqL=E3a1gVvWH8yGqYrP+ZqqO-pW9Q@mail.gmail.com>
Hi Ashwin,
On 31/03/14 18:25, Ashwin Chaugule wrote:
> On 31 March 2014 13:09, Ashwin Chaugule <ashwin.chaugule@linaro•org> wrote:
>> Hi Sudeep,
>>
>> On 31 March 2014 12:52, Sudeep Holla <sudeep.holla@arm•com> wrote:
>>
>>>> + if (ver == PSCI_RET_EOPNOTSUPP) {
>>>> + pr_info("PSCI_ID_VERSION Function not supported in firmware.\n");
>>>
>>> IMO you should stop here as the implementation conforming to the specification
>>> must return a minor version number of 2 and major version number of 0. You
>>> can't proceed, assume ids and use them.
>>>
>>
>> hm, you're right, I missed that.
>
> Something like this?
>
> if (ver == PSCI_RET_EOPNOTSUPP) {
> /* PSCI v0.2+ mandates implementation of PSCI_ID_VERSION. */
> pr_err("PSCI firmware does not comply with the v0.2 spec.\n");
> err = -EOPNOTSUPP;
> goto out_put_node;
>
Yes that looks fine to me.
Regards,
Sudeep
next prev parent reply other threads:[~2014-03-31 18:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-31 15:02 [PATCH v4 0/3] PSCI v0.2 support and DT bindings Ashwin Chaugule
2014-03-31 15:02 ` [PATCH v4 1/3] PSCI: Add initial support for PSCIv0.2 functions Ashwin Chaugule
2014-03-31 16:52 ` [Linaro-acpi] " Sudeep Holla
2014-03-31 17:09 ` Ashwin Chaugule
2014-03-31 17:25 ` Ashwin Chaugule
2014-03-31 18:25 ` Sudeep Holla [this message]
2014-03-31 15:02 ` [PATCH v4 2/3] Documentation: devicetree: Add new binding for PSCIv0.2 Ashwin Chaugule
2014-03-31 15:02 ` [PATCH v4 3/3] ARM: Check if a CPU has gone offline Ashwin Chaugule
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5339B31E.5090406@arm.com \
--to=sudeep.holla@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox